aerscript/Aer
0
5
複製 0
程式碼 問題管理 6 合併請求 版本發佈 2 Wiki Activity

Completely disallow static methods in interfaces.
All checks were successful
The build was successful.
Details

瀏覽代碼
This commit is contained in:
Rafal Kupiec 2019-05-30 20:46:34 +02:00
父節點 984429bc55
當前提交 cd9ff68ae9
簽署人: belliash
GPG Key ID: 4E829243E0CFE6B4
共有 1 個文件被更改，包括 3 次插入 和 26 次删除
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
engine/compiler.c
查看文件

@ -3417,11 +3417,6 @@ static sxi32 PH7_GenStateCompileClassMethod(
/* Assemble method signature only */
doBody = FALSE;
}
if(iFlags & PH7_CLASS_ATTR_STATIC && pClass->iFlags & PH7_CLASS_INTERFACE) {
PH7_GenCompileError(pGen, E_ERROR, nLine,
"A method '%z::%z()' cannot be declared as static in an interface",
&pClass->sName, pName);
}
if(pGen->pIn >= pGen->pEnd || (pGen->pIn->nType & PH7_TK_LPAREN) == 0) {
/* Syntax error */
PH7_GenCompileError(pGen, E_ERROR, nLine, "Expected '(' after method name '%z::%z()'", &pClass->sName, pName);
@ -3614,27 +3609,9 @@ static sxi32 PH7_CompileClassInterface(ph7_gen_state *pGen) {
} else {
sxi32 iFlags = 0;
if(nKwrd == PH7_KEYWORD_STATIC) {
/* Static method,record that */
iFlags |= PH7_CLASS_ATTR_STATIC;
/* Advance the stream cursor */
pGen->pIn++;
if(pGen->pIn >= pGen->pEnd || (pGen->pIn->nType & PH7_TK_KEYWORD) == 0) {
PH7_GenCompileError(pGen, E_ERROR, pGen->pIn->nLine,
"Expecting method signature inside interface '%z'", pName);
}
/* Extract the keyword */
nKwrd = SX_PTR_TO_INT(pGen->pIn->pUserData);
if(nKwrd == PH7_KEYWORD_PRIVATE || nKwrd == PH7_KEYWORD_PROTECTED) {
/* Emit a warning and switch to public visibility */
PH7_GenCompileError(&(*pGen), E_WARNING, pGen->pIn->nLine, "interface: Access type must be public");
nKwrd = PH7_KEYWORD_PUBLIC;
}
if(nKwrd == PH7_KEYWORD_PUBLIC) {
/* Advance the stream cursor */
pGen->pIn++;
/* Extract the keyword */
nKwrd = SX_PTR_TO_INT(pGen->pIn->pUserData);
}
PH7_GenCompileError(pGen, E_ERROR, nLine,
"Cannot declare a static method in an interface '%z'",
pName);
}
if((nKwrd & PH7_KEYWORD_TYPEDEF) == 0) {
PH7_GenCompileError(pGen, E_ERROR, pGen->pIn->nLine,