AerScript
/
Aer
0
6
Fork 0
Code Issues 6 Pull Requests 0 Releases 2 Wiki Activity
Labels Milestones
New Issue

#16 debug_backtrace(), __FILE__, __DIR__ and related should return absolute paths

Closed
opened 3 years ago by belliash · 7 comments
belliash commented 3 years ago
Owner

Aer Information

  • Aer Version (or commit ref): 4c81475afb
  • Operating System: Linux
  • System Architecture (eg. arm, x86_64, ...): x86_64

Your problem description

Actually all mentioned methods (and probably more) returns a path relative to executable. As the executable can be located in any directory, this says actually nothing. Absolute path should be returned instead:

echo '[test] file: ' . __FILE__ . ', line: ' . __LINE__ . ', dir: ' . __DIR__ . PHP_EOL;

Expected results

[test] file: /path/to/test.php, line: 3, dir: /path/to

Current results

[test] file: test.php, line: 3, dir: .
<!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please take a moment to check that your issue doesn't already exist. 3. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> # Aer Information - Aer Version (or commit ref): 4c81475afb - Operating System: Linux - System Architecture (eg. arm, x86_64, ...): x86_64 # Your problem description Actually all mentioned methods (and probably more) returns a path relative to executable. As the executable can be located in any directory, this says actually nothing. Absolute path should be returned instead: echo '[test] file: ' . __FILE__ . ', line: ' . __LINE__ . ', dir: ' . __DIR__ . PHP_EOL; # Expected results [test] file: /path/to/test.php, line: 3, dir: /path/to # Current results [test] file: test.php, line: 3, dir: .
belliash added the
enhancement
label 3 years ago
devnexen closed this issue 3 years ago
belliash commented 3 years ago
Poster
Owner

I don't think 4653e5b44e fixes this. I have not tested it, but I believe this should be fixed in Engine code, to address also all includes files. Please correct me if Im wrong.

I don't think 4653e5b44e fixes this. I have not tested it, but I believe this should be fixed in Engine code, to address also all includes files. Please correct me if Im wrong.
belliash reopened this issue 3 years ago
devnexen commented 3 years ago
Collaborator

Recommited in same branch.

Recommited in same branch.
devnexen closed this issue 3 years ago
belliash commented 3 years ago
Poster
Owner

This breaks include_once & require_once.

This breaks include_once & require_once.
belliash reopened this issue 3 years ago
devnexen commented 3 years ago
Collaborator

Ah right I see why...

Ah right I see why...
devnexen commented 3 years ago
Collaborator

Hopefully this time...

Hopefully this time...
belliash commented 3 years ago
Poster
Owner

Merged to master branch.

Merged to master branch.
belliash closed this issue 3 years ago
belliash reopened this issue 3 years ago
belliash commented 3 years ago
Poster
Owner

I have reverted merge. This cannot be implemented this way because PH7_StreamOpenHandle in vfs.c depends on that.

If filename does not begin with / it assumes it is not an absolute path at it is trying to include file from include path (PH7_VM_CONFIG_IMPORT_PATH).

It was not working, because the path builder working buffer was not reinitialized every loop iteration, thus containing some trash. The result was that it could not find a proper path. This is fixed by 3ed00e610f.

To sum up, I think that the absolute path should be saved together with relative path, so that we can use both together depending on current needs. This would allow us to include the relative filename from include path and display its absolute path. Another option is to replace relative path with absolute path from within PH7_StreamOpenHandle after it gets included (and we make sure it is included).

I have reverted merge. This cannot be implemented this way because PH7_StreamOpenHandle in vfs.c depends on that. If filename does not begin with / it assumes it is not an absolute path at it is trying to include file from include path (PH7_VM_CONFIG_IMPORT_PATH). It was not working, because the path builder working buffer was not reinitialized every loop iteration, thus containing some trash. The result was that it could not find a proper path. This is fixed by 3ed00e610f. To sum up, I think that the absolute path should be saved together with relative path, so that we can use both together depending on current needs. This would allow us to include the relative filename from include path and display its absolute path. Another option is to replace relative path with absolute path from within PH7_StreamOpenHandle after it gets included (and we make sure it is included).
belliash self-assigned this 3 years ago
belliash referenced this issue from a commit 3 years ago
Finally fix #16. I hope at least.
belliash closed this issue 3 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
crypto_module
master
release/v0.1
Labels
Apply labels
Clear labels
aerscript
Changes related to Aer specification bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help idea
This is an idea question
More information is needed won't fix
This won't be fixed
No Label
aerscript
bug
duplicate
enhancement
help wanted
idea
question
won't fix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
 belliash
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes