#28 include functions syntax

Closed
opened 2 years ago by belliash · 5 comments
belliash commented 2 years ago
Owner

Aer Information

  • Aer Version (or commit ref): 48b2e9d1c6
  • Operating System: Linux
  • System Architecture (eg. arm, x86_64, ...): x86_64

Your problem description

Include functions [include(), include_once(), require(), require_once()] does not check for opening and closing bracket. They can be called both:

include('file.php');

and

include 'file.php';

As there is no limit of using including function and such instruction can be put anywhere, IMHO it should have syntax like standard function.

Expected results

include 'file.php'; should fail.

Current results

no error about wrong syntax.

<!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please take a moment to check that your issue doesn't already exist. 3. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> # Aer Information - Aer Version (or commit ref): 48b2e9d1c6 - Operating System: Linux - System Architecture (eg. arm, x86_64, ...): x86_64 # Your problem description Include functions [include(), include_once(), require(), require_once()] does not check for opening and closing bracket. They can be called both: include('file.php'); and include 'file.php'; As there is no limit of using including function and such instruction can be put anywhere, IMHO it should have syntax like standard function. # Expected results include 'file.php'; should fail. # Current results no error about wrong syntax.
belliash added the
bug
label 2 years ago
belliash commented 2 years ago
Poster
Owner

Should we treat this as a bug? Should we change this?
What is your opinion?

Should we treat this as a bug? Should we change this? What is your opinion?
belliash removed the
bug
label 2 years ago
belliash added the
idea
label 2 years ago
likoski commented 2 years ago
Poster
Owner

In my opinion, syntax should be consistent. Let's do it.

In my opinion, syntax should be consistent. Let's do it.
belliash self-assigned this 2 years ago
belliash commented 2 years ago
Poster
Owner

Will be done in compiler_rework branch.

Will be done in compiler_rework branch.
belliash commented 2 years ago
Poster
Owner
b5fe36c14b
belliash commented 2 years ago
Poster
Owner
9100bf0696
belliash closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.