Implementation exec-alike function

likoski okomentoval

2018-07-29 13:57:36 +02:00

Vlastník

Aer misses some kind of exec() or system(). It might be very useful, especially on embedded devices to interact with system and other software. I think we should implements it before 1.0.

likoski přidal/a

enhancement

idea

štítky 2018-07-29 13:57:36 +02:00

belliash okomentoval

2018-07-29 16:09:33 +02:00

Vlastník

Generally speaking, I think this is good idea.

int exec(string $cmd, [string &$output]);

First argument contains command to execute, second parameter will contains output from command execution if passed by reference.

Function returns -1 if any error ocurred, or command return value.

Some other ideas?

Generally speaking, I think this is good idea. int exec(string $cmd, [string &$output]); First argument contains command to execute, second parameter will contains output from command execution if passed by reference. Function returns -1 if any error ocurred, or command return value. Some other ideas?

devnexen okomentoval

2018-07-31 17:41:32 +02:00

Člen

Should we get also a potential error reason ? (like from errno for example)

belliash okomentoval

2018-07-31 18:30:27 +02:00

Vlastník

What kind of error do we expect? If application launched throw error it should be saved in $output and its return code should be returned by exec() function. Do we need something more?

devnexen okomentoval

2018-07-31 20:07:26 +02:00

Člen

All exec* sets errno internally, was just wondering if we should return the string error as third parameter (optional).

Not forcing anything here, it is good as is too.

All exec* sets errno internally, was just wondering if we should return the string error as third parameter (optional). Not forcing anything here, it is good as is too.

belliash okomentoval

2018-07-31 20:12:34 +02:00

Vlastník

This is true. I just wonder in which case it could be useful, because actually I don't find a reason why it might fail, except when exec() would be disabled.

belliash odkázal na tento úkol z commitu

2018-08-16 16:18:56 +02:00

There is no need for include_once() and require_once() Aer is object-oriented language and the code it includes is executed in the global scope. Global scope can contain only classes and namespaces and they cannot be re-declared. Thus every file can be included just once. We can leave this to programmer, or take care about it on interpreter side. With this commit, include() and require() builtin functions allows to load file just once. Thanks to that, there is no need for include_once() and require_once(). Done in scope of #30.

Implementation exec-alike function #30