#34 KeywordCode() function does not match the exact token and does not check the token length

Closed
opened 2 years ago by belliash · 1 comments
belliash commented 2 years ago
Owner

AerScript Information

  • Aer Version (or commit ref): eb30745e6e
  • Operating System: Linux
  • System Architecture (eg. arm, x86_64, ...): x86_64

Your problem description

Two weeks ago, with dff0a5c968 commit, I have reimplemented the KeywordCode() function. Originally it contained some generated code that was hard to work with. The new version is much easier, but introduces one serious bug, that currently breaks the if() { } else {} expression. At least I don't know about any other issues yet.
The root cause here, is that pTokenLookup structure implements the list of keywords and KeywordCode() tries to match the extracted text from source file to the keyword. However if there are several keywords containing similar name (eg. else and elseif) then the first one is matched. This function does not match the exact token and do not check the length.
Because elseif is listed before else, the construction is not working. Interpreter matches else keyword to the PH7_TKWRD_ELIF instead of PH7_TKWRD_ELSE.
Simple test:

$a = 1;
if($a) {
} else {
}

Expected results

if($a) {} else {} should work, but actually it is generating syntax error about missing opening bracket after else keyword.

Current results

Error: if/else/elseif: Missing '(' in test.aer:3
Compile error

<!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please take a moment to check that your issue doesn't already exist. 3. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> # AerScript Information - Aer Version (or commit ref): eb30745e6e - Operating System: Linux - System Architecture (eg. arm, x86_64, ...): x86_64 # Your problem description Two weeks ago, with dff0a5c968 commit, I have reimplemented the KeywordCode() function. Originally it contained some generated code that was hard to work with. The new version is much easier, but introduces one serious bug, that currently breaks the if() { } else {} expression. At least I don't know about any other issues yet. The root cause here, is that pTokenLookup structure implements the list of keywords and KeywordCode() tries to match the extracted text from source file to the keyword. However if there are several keywords containing similar name (eg. else and elseif) then the first one is matched. This function does not match the exact token and do not check the length. Because elseif is listed before else, the construction is not working. Interpreter matches __else__ keyword to the PH7_TKWRD_ELIF instead of PH7_TKWRD_ELSE. Simple test: $a = 1; if($a) { } else { } # Expected results if($a) {} else {} should work, but actually it is generating syntax error about missing opening bracket after else keyword. # Current results Error: if/else/elseif: Missing '(' in test.aer:3 Compile error
belliash added the
bug
label 2 years ago
belliash commented 2 years ago
Poster
Owner

The quick workaround to fix the if ... else construct, is to move PH7_TKWRD_ELSE before PH7_TKWRD_ELIF.

The quick workaround to fix the __if ... else__ construct, is to move PH7_TKWRD_ELSE before PH7_TKWRD_ELIF.
belliash self-assigned this 2 years ago
belliash closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.