aerscript/Aer
0
5
Fork 0
Code Issues 6 Pull Requests Releases 2 Wiki Activity

Native builtin functions implementation #42

New Issue
Closed
opened 2018-08-15 18:45:42 +02:00 by belliash · 2 comments
belliash commented 2018-08-15 18:45:42 +02:00
Owner
Copy Link

There are several function implemented as a builtin library, that is compiled and interpreted everytime during interpreter execution. They supplement the list of builtin functions. There are two reasons to reimplement them as a builtin functions:

  • native C implementation will be compiled to machine code, thus will be faster,
  • builtin function can be moved to module and consume less memory,
  • after compiler rewrite it will deny defining a functions in global scope

Functions that need to be reimplemented:

  • scandir()
  • glob()
  • tmpfile()
  • array_unshift()
  • array_merge_recursive()
  • fileowner()
  • filegroup()
  • fileinode()

Their actual implementation looks as follows:

#define PH7_BUILTIN_LIB \
"function scandir(string $directory,int $sort_order = SCANDIR_SORT_ASCENDING)"\
"{"\
"  if( func_num_args() < 1 ){ return FALSE; }"\
"  $aDir = array();"\
"  $pHandle = opendir($directory);"\
"  if( $pHandle == FALSE ){ return FALSE; }"\
"  while(FALSE !== ($pEntry = readdir($pHandle)) ){"\
"      $aDir[] = $pEntry;"\
"   }"\
"  closedir($pHandle);"\
"  if( $sort_order == SCANDIR_SORT_DESCENDING ){"\
"      rsort($aDir);"\
"  }else if( $sort_order == SCANDIR_SORT_ASCENDING ){"\
"      sort($aDir);"\
"  }"\
"  return $aDir;"\
"}"\
"function glob(string $pattern,int $iFlags = 0){"\
"/* Open the target directory */"\
"$zDir = dirname($pattern);"\
"if(!is_string($zDir) ){ $zDir = './'; }"\
"$pHandle = opendir($zDir);"\
"if( $pHandle == FALSE ){"\
"   /* IO error while opening the current directory,return FALSE */"\
"	return FALSE;"\
"}"\
"$pattern = basename($pattern);"\
"$pArray = array(); /* Empty array */"\
"/* Loop throw available entries */"\
"while( FALSE !== ($pEntry = readdir($pHandle)) ){"\
" /* Use the built-in strglob function which is a Symisc eXtension for wildcard comparison*/"\
"	$rc = strglob($pattern,$pEntry);"\
"	if( $rc ){"\
"	   if( is_dir($pEntry) ){"\
"	      if( $iFlags & GLOB_MARK ){"\
"		     /* Adds a slash to each directory returned */"\
"			 $pEntry += DIRECTORY_SEPARATOR;"\
"		  }"\
"	   }else if( $iFlags & GLOB_ONLYDIR ){"\
"	     /* Not a directory,ignore */"\
"		 continue;"\
"	   }"\
"	   /* Add the entry */"\
"	   $pArray[] = $pEntry;"\
"	}"\
" }"\
"/* Close the handle */"\
"closedir($pHandle);"\
"if( ($iFlags & GLOB_NOSORT) == 0 ){"\
"  /* Sort the array */"\
"  sort($pArray);"\
"}"\
"if( ($iFlags & GLOB_NOCHECK) && sizeof($pArray) < 1 ){"\
"  /* Return the search pattern if no files matching were found */"\
"  $pArray[] = $pattern;"\
"}"\
"/* Return the created array */"\
"return $pArray;"\
"}"\
"/* Creates a temporary file */"\
"function tmpfile(){"\
"  /* Extract the temp directory */"\
"  $zTempDir = sys_get_temp_dir();"\
"  if( strlen($zTempDir) < 1 ){"\
"    /* Use the current dir */"\
"    $zTempDir = '.';"\
"  }"\
"  /* Create the file */"\
"  $pHandle = fopen($zTempDir+DIRECTORY_SEPARATOR+'PH7'+rand_str(12),'w+');"\
"  return $pHandle;"\
"}"\
"function array_unshift(&$pArray ){"\
" if( func_num_args() < 1 || !is_array($pArray) ){  return 0; }"\
"/* Copy arguments */"\
"$nArgs = func_num_args();"\
"$pNew = array();"\
"for( $i = 1 ; $i < $nArgs ; ++$i ){"\
" $pNew[] = func_get_arg($i);"\
"}"\
"/* Make a copy of the old entries */"\
"$pOld = array_copy($pArray);"\
"/* Erase */"\
"array_erase($pArray);"\
"/* Unshift */"\
"$pArray = array_merge($pNew,$pOld);"\
"return sizeof($pArray);"\
"}"\
"function array_merge_recursive($array1, $array2){"\
"if( func_num_args() < 1 ){ return NULL; }"\
"$arrays = func_get_args();"\
"$narrays = sizeof($arrays);"\
"$ret = $arrays[0];"\
"for ($i = 1; $i < $narrays; $i++) {"\
" if( array_same($ret,$arrays[$i]) ){ /* Same instance */continue;}"\
" foreach ($arrays[$i] as $key => $value) {"\
"  if (((string) $key) === ((string) intval($key))) {"\
"   $ret[] = $value;"\
"  }else{"\
"  if (is_array($value) && isset($ret[$key]) ) {"\
"   $ret[$key] = array_merge_recursive($ret[$key], $value);"\
" }else {"\
"   $ret[$key] = $value;"\
"  }"\
" }"\
" }"\
"}"\
" return $ret;"\
"}"\
"function fileowner(string $file){"\
" $a = stat($file);"\
" if( !is_array($a) ){"\
"	return false;"\
" }"\
" return $a['uid'];"\
"}"\
"function filegroup(string $file){"\
" $a = stat($file);"\
" if( !is_array($a) ){"\
"	return false;"\
" }"\
" return $a['gid'];"\
"}"\
"function fileinode(string $file){"\
" $a = stat($file);"\
" if( !is_array($a) ){"\
"	return false;"\
" }"\
" return $a['ino'];"\
"}"
There are several function implemented as a builtin library, that is compiled and interpreted everytime during interpreter execution. They supplement the list of builtin functions. There are two reasons to reimplement them as a builtin functions: * native C implementation will be compiled to machine code, thus will be faster, * builtin function can be moved to module and consume less memory, * after compiler rewrite it will deny defining a functions in global scope Functions that need to be reimplemented: * scandir() * glob() * tmpfile() * array_unshift() * array_merge_recursive() * fileowner() * filegroup() * fileinode() Their actual implementation looks as follows: #define PH7_BUILTIN_LIB \ "function scandir(string $directory,int $sort_order = SCANDIR_SORT_ASCENDING)"\ "{"\ " if( func_num_args() < 1 ){ return FALSE; }"\ " $aDir = array();"\ " $pHandle = opendir($directory);"\ " if( $pHandle == FALSE ){ return FALSE; }"\ " while(FALSE !== ($pEntry = readdir($pHandle)) ){"\ " $aDir[] = $pEntry;"\ " }"\ " closedir($pHandle);"\ " if( $sort_order == SCANDIR_SORT_DESCENDING ){"\ " rsort($aDir);"\ " }else if( $sort_order == SCANDIR_SORT_ASCENDING ){"\ " sort($aDir);"\ " }"\ " return $aDir;"\ "}"\ "function glob(string $pattern,int $iFlags = 0){"\ "/* Open the target directory */"\ "$zDir = dirname($pattern);"\ "if(!is_string($zDir) ){ $zDir = './'; }"\ "$pHandle = opendir($zDir);"\ "if( $pHandle == FALSE ){"\ " /* IO error while opening the current directory,return FALSE */"\ " return FALSE;"\ "}"\ "$pattern = basename($pattern);"\ "$pArray = array(); /* Empty array */"\ "/* Loop throw available entries */"\ "while( FALSE !== ($pEntry = readdir($pHandle)) ){"\ " /* Use the built-in strglob function which is a Symisc eXtension for wildcard comparison*/"\ " $rc = strglob($pattern,$pEntry);"\ " if( $rc ){"\ " if( is_dir($pEntry) ){"\ " if( $iFlags & GLOB_MARK ){"\ " /* Adds a slash to each directory returned */"\ " $pEntry += DIRECTORY_SEPARATOR;"\ " }"\ " }else if( $iFlags & GLOB_ONLYDIR ){"\ " /* Not a directory,ignore */"\ " continue;"\ " }"\ " /* Add the entry */"\ " $pArray[] = $pEntry;"\ " }"\ " }"\ "/* Close the handle */"\ "closedir($pHandle);"\ "if( ($iFlags & GLOB_NOSORT) == 0 ){"\ " /* Sort the array */"\ " sort($pArray);"\ "}"\ "if( ($iFlags & GLOB_NOCHECK) && sizeof($pArray) < 1 ){"\ " /* Return the search pattern if no files matching were found */"\ " $pArray[] = $pattern;"\ "}"\ "/* Return the created array */"\ "return $pArray;"\ "}"\ "/* Creates a temporary file */"\ "function tmpfile(){"\ " /* Extract the temp directory */"\ " $zTempDir = sys_get_temp_dir();"\ " if( strlen($zTempDir) < 1 ){"\ " /* Use the current dir */"\ " $zTempDir = '.';"\ " }"\ " /* Create the file */"\ " $pHandle = fopen($zTempDir+DIRECTORY_SEPARATOR+'PH7'+rand_str(12),'w+');"\ " return $pHandle;"\ "}"\ "function array_unshift(&$pArray ){"\ " if( func_num_args() < 1 || !is_array($pArray) ){ return 0; }"\ "/* Copy arguments */"\ "$nArgs = func_num_args();"\ "$pNew = array();"\ "for( $i = 1 ; $i < $nArgs ; ++$i ){"\ " $pNew[] = func_get_arg($i);"\ "}"\ "/* Make a copy of the old entries */"\ "$pOld = array_copy($pArray);"\ "/* Erase */"\ "array_erase($pArray);"\ "/* Unshift */"\ "$pArray = array_merge($pNew,$pOld);"\ "return sizeof($pArray);"\ "}"\ "function array_merge_recursive($array1, $array2){"\ "if( func_num_args() < 1 ){ return NULL; }"\ "$arrays = func_get_args();"\ "$narrays = sizeof($arrays);"\ "$ret = $arrays[0];"\ "for ($i = 1; $i < $narrays; $i++) {"\ " if( array_same($ret,$arrays[$i]) ){ /* Same instance */continue;}"\ " foreach ($arrays[$i] as $key => $value) {"\ " if (((string) $key) === ((string) intval($key))) {"\ " $ret[] = $value;"\ " }else{"\ " if (is_array($value) && isset($ret[$key]) ) {"\ " $ret[$key] = array_merge_recursive($ret[$key], $value);"\ " }else {"\ " $ret[$key] = $value;"\ " }"\ " }"\ " }"\ "}"\ " return $ret;"\ "}"\ "function fileowner(string $file){"\ " $a = stat($file);"\ " if( !is_array($a) ){"\ " return false;"\ " }"\ " return $a['uid'];"\ "}"\ "function filegroup(string $file){"\ " $a = stat($file);"\ " if( !is_array($a) ){"\ " return false;"\ " }"\ " return $a['gid'];"\ "}"\ "function fileinode(string $file){"\ " $a = stat($file);"\ " if( !is_array($a) ){"\ " return false;"\ " }"\ " return $a['ino'];"\ "}"
belliash added the
enhancement
 label 2018-08-15 18:45:42 +02:00
belliash commented 2018-08-15 22:03:45 +02:00
Author
Owner
Copy Link

Left:

  • scandir()
  • glob()
  • tmpfile()
  • array_unshift()
  • array_merge_recursive()
Left: * scandir() * glob() * tmpfile() * array_unshift() * array_merge_recursive()
belliash self-assigned this 2019-06-07 19:28:56 +02:00
belliash removed their assignment 2019-06-07 19:29:05 +02:00
belliash self-assigned this 2019-06-07 19:29:06 +02:00
belliash commented 2019-06-07 19:29:14 +02:00
Author
Owner
Copy Link

Builtin library needs to be redesigned, as it actually follows the PHP. Some functions use prefix + underscore, while others use C-Style (abbreviated words crunched together). Numerous functions can be found in the library that are aliases for each other and do the exact same thing, which is rather confusing to say the least. Even the order of parameters varies between different functions of similar kind. This all just sucks and have to be rearranged.

Actually closing this ticket, as there is a plan to completely rework the builtin library.

Builtin library needs to be redesigned, as it actually follows the PHP. Some functions use prefix + underscore, while others use C-Style (abbreviated words crunched together). Numerous functions can be found in the library that are aliases for each other and do the exact same thing, which is rather confusing to say the least. Even the order of parameters varies between different functions of similar kind. This all just sucks and have to be rearranged. Actually closing this ticket, as there is a plan to completely rework the builtin library.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
aerscript
Changes related to Aer specification
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
idea
This is an idea
question
More information is needed
won't fix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
belliash devnexen
No Assignees belliash
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aerscript/Aer#42
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?