Small code nits #54
标签
未选择里程碑
未指派成员
2 名参与者
通知
到期时间
未设置到期时间。
依赖工单
没有设置依赖项。
参考：aerscript/Aer#54
正在加载...
在新工单中引用
屏蔽一个用户
没有提供说明。
删除分支 %!s()
删除分支是永久的。虽然已删除的分支在实际被删除前有可能会短时间存在，但这在大多数情况下无法撤销。是否继续？
Few compiler warning I get with current code on master :
engine/vm.c / line 941, the last argument might deserve an explicit cast.include/ph7int.h / line 1892;engine/lib/libzip.c / line 514, just stylistic hereno newline at end of file.Do they come from GCC or any other compiler? Could you post the entire build log?
gcc 8 in my part :
engine/vm.c: In function ‘PH7_VmInit’: engine/vm.c:941:56: warning: passing argument 4 of ‘SyHashInit’ from incompatible pointer type [-Wincompatible-pointer-types] SyHashInit(&pVm->hClass, &pVm->sAllocator, SyStrHash, SyStrncmp);signature of the callback not really matching, seems "picky" here IMHO but a cast would not kill.This is not as simple to correct. The callback function is used in several places and its signature does not match only here.
I meant the cast only on this line but as said that s cosmetic, it works as it anyway.
I think, we can cast this just to remove this ugly warning. Anyway you will need to commit a fix, as I have a faulty PC and currently cannot work on AerScript. Im waiting for hardware I ordered.