debug_backtrace(), FILE, DIR and related should return absolute paths #16

New Issue

Closed

opened 2018-07-22 16:32:26 +02:00 by belliash · 7 comments

belliash commented

2018-07-22 16:32:26 +02:00

Owner

Aer Information

Aer Version (or commit ref): 4c81475afb
Operating System: Linux
System Architecture (eg. arm, x86_64, ...): x86_64

Your problem description

Actually all mentioned methods (and probably more) returns a path relative to executable. As the executable can be located in any directory, this says actually nothing. Absolute path should be returned instead:

echo '[test] file: ' . __FILE__ . ', line: ' . __LINE__ . ', dir: ' . __DIR__ . PHP_EOL;

Expected results

[test] file: /path/to/test.php, line: 3, dir: /path/to

Current results

[test] file: test.php, line: 3, dir: .

# Aer Information - Aer Version (or commit ref): 4c81475afb - Operating System: Linux - System Architecture (eg. arm, x86_64, ...): x86_64 # Your problem description Actually all mentioned methods (and probably more) returns a path relative to executable. As the executable can be located in any directory, this says actually nothing. Absolute path should be returned instead: echo '[test] file: ' . __FILE__ . ', line: ' . __LINE__ . ', dir: ' . __DIR__ . PHP_EOL; # Expected results [test] file: /path/to/test.php, line: 3, dir: /path/to # Current results [test] file: test.php, line: 3, dir: .

belliash added the

enhancement

label 2018-07-22 16:32:26 +02:00

devnexen referenced this issue from a commit

2018-07-22 22:47:33 +02:00

Fix #16 might needs to test under Windows.

devnexen closed this issue

2018-07-22 22:47:33 +02:00

devnexen referenced this issue from a commit

2018-07-22 22:52:45 +02:00

Fix #16 might needs to test under Windows.

belliash commented

2018-07-23 06:23:45 +02:00

Author

Owner

I don't think 4653e5b44e fixes this. I have not tested it, but I believe this should be fixed in Engine code, to address also all includes files. Please correct me if Im wrong.

I don't think 4653e5b44e fixes this. I have not tested it, but I believe this should be fixed in Engine code, to address also all includes files. Please correct me if Im wrong.

belliash reopened this issue

2018-07-23 06:23:45 +02:00

devnexen commented

2018-07-23 07:10:41 +02:00

Member

Recommited in same branch.

devnexen closed this issue

2018-07-23 07:10:41 +02:00

belliash commented

2018-07-23 07:22:41 +02:00

Author

Owner

This breaks include_once & require_once.

belliash reopened this issue

2018-07-23 07:22:41 +02:00

devnexen commented

2018-07-23 07:26:50 +02:00

Member

Ah right I see why...

devnexen commented

2018-07-23 07:35:38 +02:00

Member

Hopefully this time...

belliash commented

2018-07-23 07:50:51 +02:00

Author

Owner

Merged to master branch.

belliash closed this issue

2018-07-23 07:50:51 +02:00

belliash reopened this issue

2018-07-23 19:40:26 +02:00

belliash commented

2018-07-23 19:46:31 +02:00

Author

Owner

I have reverted merge. This cannot be implemented this way because PH7_StreamOpenHandle in vfs.c depends on that.

If filename does not begin with / it assumes it is not an absolute path at it is trying to include file from include path (PH7_VM_CONFIG_IMPORT_PATH).

It was not working, because the path builder working buffer was not reinitialized every loop iteration, thus containing some trash. The result was that it could not find a proper path. This is fixed by 3ed00e610f.

To sum up, I think that the absolute path should be saved together with relative path, so that we can use both together depending on current needs. This would allow us to include the relative filename from include path and display its absolute path. Another option is to replace relative path with absolute path from within PH7_StreamOpenHandle after it gets included (and we make sure it is included).

I have reverted merge. This cannot be implemented this way because PH7_StreamOpenHandle in vfs.c depends on that. If filename does not begin with / it assumes it is not an absolute path at it is trying to include file from include path (PH7_VM_CONFIG_IMPORT_PATH). It was not working, because the path builder working buffer was not reinitialized every loop iteration, thus containing some trash. The result was that it could not find a proper path. This is fixed by 3ed00e610f. To sum up, I think that the absolute path should be saved together with relative path, so that we can use both together depending on current needs. This would allow us to include the relative filename from include path and display its absolute path. Another option is to replace relative path with absolute path from within PH7_StreamOpenHandle after it gets included (and we make sure it is included).

belliash referenced this issue from a commit

2018-07-24 09:07:41 +02:00

This partially implements #16 - currently only for entry file.

belliash self-assigned this 2018-07-24 10:10:45 +02:00

belliash referenced this issue from a commit

2018-07-24 10:11:24 +02:00

Finally fix #16. I hope at least.

belliash closed this issue

2018-07-24 10:11:24 +02:00