System Architecture (eg. arm, x86_64, ...): x86_64
Your problem description
Actually all mentioned methods (and probably more) returns a path relative to executable. As the executable can be located in any directory, this says actually nothing. Absolute path should be returned instead:
<!--
1. Please speak English, this is the language all of us can speak and write.
2. Please take a moment to check that your issue doesn't already exist.
3. Please give all relevant information below for bug reports, because
incomplete details will be handled as an invalid report.
-->
# Aer Information
- Aer Version (or commit ref): 4c81475afb
- Operating System: Linux
- System Architecture (eg. arm, x86_64, ...): x86_64
# Your problem description
Actually all mentioned methods (and probably more) returns a path relative to executable. As the executable can be located in any directory, this says actually nothing. Absolute path should be returned instead:
echo '[test] file: ' . __FILE__ . ', line: ' . __LINE__ . ', dir: ' . __DIR__ . PHP_EOL;
# Expected results
[test] file: /path/to/test.php, line: 3, dir: /path/to
# Current results
[test] file: test.php, line: 3, dir: .
I don't think 4653e5b44e fixes this. I have not tested it, but I believe this should be fixed in Engine code, to address also all includes files. Please correct me if Im wrong.
I don't think 4653e5b44e fixes this. I have not tested it, but I believe this should be fixed in Engine code, to address also all includes files. Please correct me if Im wrong.
I have reverted merge. This cannot be implemented this way because PH7_StreamOpenHandle in vfs.c depends on that.
If filename does not begin with / it assumes it is not an absolute path at it is trying to include file from include path (PH7_VM_CONFIG_IMPORT_PATH).
It was not working, because the path builder working buffer was not reinitialized every loop iteration, thus containing some trash. The result was that it could not find a proper path. This is fixed by 3ed00e610f.
To sum up, I think that the absolute path should be saved together with relative path, so that we can use both together depending on current needs. This would allow us to include the relative filename from include path and display its absolute path. Another option is to replace relative path with absolute path from within PH7_StreamOpenHandle after it gets included (and we make sure it is included).
I have reverted merge. This cannot be implemented this way because PH7_StreamOpenHandle in vfs.c depends on that.
If filename does not begin with / it assumes it is not an absolute path at it is trying to include file from include path (PH7_VM_CONFIG_IMPORT_PATH).
It was not working, because the path builder working buffer was not reinitialized every loop iteration, thus containing some trash. The result was that it could not find a proper path. This is fixed by 3ed00e610f.
To sum up, I think that the absolute path should be saved together with relative path, so that we can use both together depending on current needs. This would allow us to include the relative filename from include path and display its absolute path. Another option is to replace relative path with absolute path from within PH7_StreamOpenHandle after it gets included (and we make sure it is included).
Aer Information
4c81475afbYour problem description
Actually all mentioned methods (and probably more) returns a path relative to executable. As the executable can be located in any directory, this says actually nothing. Absolute path should be returned instead:
Expected results
Current results
I don't think
4653e5b44efixes this. I have not tested it, but I believe this should be fixed in Engine code, to address also all includes files. Please correct me if Im wrong.Recommited in same branch.
This breaks include_once & require_once.
Ah right I see why...
Hopefully this time...
Merged to master branch.
I have reverted merge. This cannot be implemented this way because PH7_StreamOpenHandle in vfs.c depends on that.
If filename does not begin with / it assumes it is not an absolute path at it is trying to include file from include path (PH7_VM_CONFIG_IMPORT_PATH).
It was not working, because the path builder working buffer was not reinitialized every loop iteration, thus containing some trash. The result was that it could not find a proper path. This is fixed by
3ed00e610f.To sum up, I think that the absolute path should be saved together with relative path, so that we can use both together depending on current needs. This would allow us to include the relative filename from include path and display its absolute path. Another option is to replace relative path with absolute path from within PH7_StreamOpenHandle after it gets included (and we make sure it is included).