aerscript/Aer
0
5
Fork 0
Code Issues 6 Pull Requests Releases 2 Wiki Activity

debug_backtrace(), __FILE__, __DIR__ and related should return absolute paths #16

New Issue
Closed
opened 2018-07-22 16:32:26 +02:00 by belliash · 7 comments
belliash commented 2018-07-22 16:32:26 +02:00
Owner
Copy Link

Aer Information

  • Aer Version (or commit ref): 4c81475afb
  • Operating System: Linux
  • System Architecture (eg. arm, x86_64, ...): x86_64

Your problem description

Actually all mentioned methods (and probably more) returns a path relative to executable. As the executable can be located in any directory, this says actually nothing. Absolute path should be returned instead:

echo '[test] file: ' . __FILE__ . ', line: ' . __LINE__ . ', dir: ' . __DIR__ . PHP_EOL;

Expected results

[test] file: /path/to/test.php, line: 3, dir: /path/to

Current results

[test] file: test.php, line: 3, dir: .
<!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please take a moment to check that your issue doesn't already exist. 3. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> # Aer Information - Aer Version (or commit ref): 4c81475afb - Operating System: Linux - System Architecture (eg. arm, x86_64, ...): x86_64 # Your problem description Actually all mentioned methods (and probably more) returns a path relative to executable. As the executable can be located in any directory, this says actually nothing. Absolute path should be returned instead: echo '[test] file: ' . __FILE__ . ', line: ' . __LINE__ . ', dir: ' . __DIR__ . PHP_EOL; # Expected results [test] file: /path/to/test.php, line: 3, dir: /path/to # Current results [test] file: test.php, line: 3, dir: .
belliash added the
enhancement
 label 2018-07-22 16:32:26 +02:00
belliash commented 2018-07-23 06:23:45 +02:00
Author
Owner
Copy Link

I don't think 4653e5b44e fixes this. I have not tested it, but I believe this should be fixed in Engine code, to address also all includes files. Please correct me if Im wrong.

I don't think 4653e5b44e fixes this. I have not tested it, but I believe this should be fixed in Engine code, to address also all includes files. Please correct me if Im wrong.
belliash reopened this issue 2018-07-23 06:23:45 +02:00
devnexen commented 2018-07-23 07:10:41 +02:00
Member
Copy Link

Recommited in same branch.

Recommited in same branch.
belliash commented 2018-07-23 07:22:41 +02:00
Author
Owner
Copy Link

This breaks include_once & require_once.

This breaks include_once & require_once.
belliash reopened this issue 2018-07-23 07:22:41 +02:00
devnexen commented 2018-07-23 07:26:50 +02:00
Member
Copy Link

Ah right I see why...

Ah right I see why...
devnexen commented 2018-07-23 07:35:38 +02:00
Member
Copy Link

Hopefully this time...

Hopefully this time...
belliash commented 2018-07-23 07:50:51 +02:00
Author
Owner
Copy Link

Merged to master branch.

Merged to master branch.
belliash reopened this issue 2018-07-23 19:40:26 +02:00
belliash commented 2018-07-23 19:46:31 +02:00
Author
Owner
Copy Link

I have reverted merge. This cannot be implemented this way because PH7_StreamOpenHandle in vfs.c depends on that.

If filename does not begin with / it assumes it is not an absolute path at it is trying to include file from include path (PH7_VM_CONFIG_IMPORT_PATH).

It was not working, because the path builder working buffer was not reinitialized every loop iteration, thus containing some trash. The result was that it could not find a proper path. This is fixed by 3ed00e610f.

To sum up, I think that the absolute path should be saved together with relative path, so that we can use both together depending on current needs. This would allow us to include the relative filename from include path and display its absolute path. Another option is to replace relative path with absolute path from within PH7_StreamOpenHandle after it gets included (and we make sure it is included).

I have reverted merge. This cannot be implemented this way because PH7_StreamOpenHandle in vfs.c depends on that. If filename does not begin with / it assumes it is not an absolute path at it is trying to include file from include path (PH7_VM_CONFIG_IMPORT_PATH). It was not working, because the path builder working buffer was not reinitialized every loop iteration, thus containing some trash. The result was that it could not find a proper path. This is fixed by 3ed00e610f. To sum up, I think that the absolute path should be saved together with relative path, so that we can use both together depending on current needs. This would allow us to include the relative filename from include path and display its absolute path. Another option is to replace relative path with absolute path from within PH7_StreamOpenHandle after it gets included (and we make sure it is included).
belliash self-assigned this 2018-07-24 10:10:45 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
aerscript
Changes related to Aer specification
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
idea
This is an idea
question
More information is needed
won't fix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
belliash devnexen
No Assignees belliash
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aerscript/Aer#16
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?