KeywordCode() function does not match the exact token and does not check the token length #34

New Issue

Closed

opened 2018-08-02 06:24:01 +02:00 by belliash · 1 comment

belliash commented

2018-08-02 06:24:01 +02:00

Owner

AerScript Information

Aer Version (or commit ref): eb30745e6e
Operating System: Linux
System Architecture (eg. arm, x86_64, ...): x86_64

Your problem description

Two weeks ago, with dff0a5c968 commit, I have reimplemented the KeywordCode() function. Originally it contained some generated code that was hard to work with. The new version is much easier, but introduces one serious bug, that currently breaks the if() { } else {} expression. At least I don't know about any other issues yet.
The root cause here, is that pTokenLookup structure implements the list of keywords and KeywordCode() tries to match the extracted text from source file to the keyword. However if there are several keywords containing similar name (eg. else and elseif) then the first one is matched. This function does not match the exact token and do not check the length.
Because elseif is listed before else, the construction is not working. Interpreter matches else keyword to the PH7_TKWRD_ELIF instead of PH7_TKWRD_ELSE.
Simple test:

$a = 1;
if($a) {
} else {
}

Expected results

if($a) {} else {} should work, but actually it is generating syntax error about missing opening bracket after else keyword.

Current results

Error: if/else/elseif: Missing '(' in test.aer:3
Compile error

# AerScript Information - Aer Version (or commit ref): eb30745e6e - Operating System: Linux - System Architecture (eg. arm, x86_64, ...): x86_64 # Your problem description Two weeks ago, with dff0a5c968 commit, I have reimplemented the KeywordCode() function. Originally it contained some generated code that was hard to work with. The new version is much easier, but introduces one serious bug, that currently breaks the if() { } else {} expression. At least I don't know about any other issues yet. The root cause here, is that pTokenLookup structure implements the list of keywords and KeywordCode() tries to match the extracted text from source file to the keyword. However if there are several keywords containing similar name (eg. else and elseif) then the first one is matched. This function does not match the exact token and do not check the length. Because elseif is listed before else, the construction is not working. Interpreter matches __else__ keyword to the PH7_TKWRD_ELIF instead of PH7_TKWRD_ELSE. Simple test: $a = 1; if($a) { } else { } # Expected results if($a) {} else {} should work, but actually it is generating syntax error about missing opening bracket after else keyword. # Current results Error: if/else/elseif: Missing '(' in test.aer:3 Compile error