Empty string is treated as NULL #35

New Issue

Closed

opened 2018-08-06 12:25:47 +02:00 by belliash · 4 comments

belliash commented

2018-08-06 12:25:47 +02:00

Owner

AerScript Information

Aer Version (or commit ref): dd239530d8
Operating System: Linux
System Architecture (eg. arm, x86_64, ...): x86_64

Your problem description

Empty string or string containing special characters like "\n" is treated by PH7 Engine as NULL instead of zero-length string. Quick example:

var_dump('');

Expected results

string(0, '');

Current results

null

# AerScript Information - Aer Version (or commit ref): dd239530d8 - Operating System: Linux - System Architecture (eg. arm, x86_64, ...): x86_64 # Your problem description Empty string or string containing special characters like "\n" is treated by PH7 Engine as NULL instead of zero-length string. Quick example: var_dump(''); # Expected results string(0, ''); # Current results null

belliash added the

bug

label 2018-08-06 12:25:47 +02:00

belliash commented

2018-08-06 13:10:13 +02:00

Poster

Owner

$x = '';
var_dump(is_string($x));

The above example also fails. It shows:

bool(FALSE)

instead of:

bool(TRUE)

I suppose, there is a problem with PH7_OP_STORE instruction.

$x = ''; var_dump(is_string($x)); The above example also fails. It shows: bool(FALSE) instead of: bool(TRUE) I suppose, there is a problem with PH7_OP_STORE instruction.

likoski commented

2018-08-06 14:40:12 +02:00

Owner

I think it takes the value as it comes from the compiler. From what I checked, it forces type to NULL if string is empty. Seems easy to fix.

likoski self-assigned this 2018-08-06 15:57:38 +02:00

likoski commented

2018-08-06 15:57:57 +02:00

Owner

Let me check if I can fix this.

likoski referenced this issue from a commit

2018-08-06 16:04:40 +02:00

Empty double-quoted string can be served as single-quoted string. Preparing for further changes in scope of #35.

likoski referenced this issue from a commit

2018-08-06 16:14:57 +02:00

It does not matter if it is empty string or not, we want to process it. Empty string should not ever been even considered as a NULL. Fixing #35.

likoski commented

2018-08-06 16:21:03 +02:00

Owner

$str1 = "This is just a test";
$str2 = "";
$str3 = 'Another test';
$str4 = '';
var_dump($str1);
var_dump($str2);
var_dump($str3);
var_dump($str4);

produces

string(19 'This is just a test')
string(0 '')
string(12 'Another test')
string(0 '')

$str1 = "This is just a test"; $str2 = ""; $str3 = 'Another test'; $str4 = ''; var_dump($str1); var_dump($str2); var_dump($str3); var_dump($str4); produces string(19 'This is just a test') string(0 '') string(12 'Another test') string(0 '')

likoski closed this issue

2018-08-06 16:21:03 +02:00