Small code nits #54
Labels
No Label
aerscript
bug
duplicate
enhancement
help wanted
idea
question
won't fix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: aerscript/Aer#54
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Few compiler warning I get with current code on master :
engine/vm.c / line 941
, the last argument might deserve an explicit cast.include/ph7int.h / line 1892
;engine/lib/libzip.c / line 514
, just stylistic hereno newline at end of file
.Do they come from GCC or any other compiler? Could you post the entire build log?
gcc 8 in my part :
engine/vm.c: In function ‘PH7_VmInit’: engine/vm.c:941:56: warning: passing argument 4 of ‘SyHashInit’ from incompatible pointer type [-Wincompatible-pointer-types] SyHashInit(&pVm->hClass, &pVm->sAllocator, SyStrHash, SyStrncmp);
signature of the callback not really matching, seems "picky" here IMHO but a cast would not kill.This is not as simple to correct. The callback function is used in several places and its signature does not match only here.
I meant the cast only on this line but as said that s cosmetic, it works as it anyway.
I think, we can cast this just to remove this ugly warning. Anyway you will need to commit a fix, as I have a faulty PC and currently cannot work on AerScript. Im waiting for hardware I ordered.