fix: ensure all post steps are executed (#1286)
This fixes an issue in the chain of post steps introduced while updating the step-logger for composite actions. It includes a test case so we make sure this does not happen again.
This commit is contained in:
10
pkg/runner/testdata/ensure-post-steps/action-composite/action.yml
vendored
Normal file
10
pkg/runner/testdata/ensure-post-steps/action-composite/action.yml
vendored
Normal file
@@ -0,0 +1,10 @@
|
||||
name: "action composite"
|
||||
description: "action composite"
|
||||
runs:
|
||||
using: composite
|
||||
steps:
|
||||
# second post action should fail if executed (we do check on the exit code)
|
||||
- uses: ./ensure-post-steps/action-post/
|
||||
with:
|
||||
fail: "true"
|
||||
- uses: ./ensure-post-steps/action-post/
|
11
pkg/runner/testdata/ensure-post-steps/action-post/action.yml
vendored
Normal file
11
pkg/runner/testdata/ensure-post-steps/action-post/action.yml
vendored
Normal file
@@ -0,0 +1,11 @@
|
||||
name: "action post"
|
||||
description: "action post"
|
||||
inputs:
|
||||
fail:
|
||||
description: "true if this should fail"
|
||||
required: false
|
||||
default: "false"
|
||||
runs:
|
||||
using: node16
|
||||
main: "./main.js"
|
||||
post: "./post.js"
|
0
pkg/runner/testdata/ensure-post-steps/action-post/main.js
vendored
Normal file
0
pkg/runner/testdata/ensure-post-steps/action-post/main.js
vendored
Normal file
3
pkg/runner/testdata/ensure-post-steps/action-post/post.js
vendored
Normal file
3
pkg/runner/testdata/ensure-post-steps/action-post/post.js
vendored
Normal file
@@ -0,0 +1,3 @@
|
||||
if (process.env["INPUT_FAIL"] === "true") {
|
||||
process.exit(1);
|
||||
}
|
8
pkg/runner/testdata/ensure-post-steps/push.yml
vendored
Normal file
8
pkg/runner/testdata/ensure-post-steps/push.yml
vendored
Normal file
@@ -0,0 +1,8 @@
|
||||
name: test
|
||||
on: push
|
||||
jobs:
|
||||
second-post-step-should-fail:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
- uses: ./ensure-post-steps/action-composite/
|
Reference in New Issue
Block a user