test: Do not leak step env in composite (#1585)
* test: Do not leak step env in composite To prevent merging regressions. * Update runner_test.go
This commit is contained in:
		| @@ -203,6 +203,7 @@ func TestRunEvent(t *testing.T) { | ||||
| 		// {"testdata", "issue-228", "push", "", platforms, }, // TODO [igni]: Remove this once everything passes | ||||
| 		{"../model/testdata", "container-volumes", "push", "", platforms, secrets}, | ||||
| 		{workdir, "path-handling", "push", "", platforms, secrets}, | ||||
| 		{workdir, "do-not-leak-step-env-in-composite", "push", "", platforms, secrets}, | ||||
| 	} | ||||
|  | ||||
| 	for _, table := range tables { | ||||
| @@ -295,12 +296,14 @@ func TestRunEventHostEnvironment(t *testing.T) { | ||||
| 		}...) | ||||
| 	} else { | ||||
| 		platforms := map[string]string{ | ||||
| 			"self-hosted": "-self-hosted", | ||||
| 			"self-hosted":   "-self-hosted", | ||||
| 			"ubuntu-latest": "-self-hosted", | ||||
| 		} | ||||
|  | ||||
| 		tables = append(tables, []TestJobFileInfo{ | ||||
| 			{workdir, "nix-prepend-path", "push", "", platforms, secrets}, | ||||
| 			{workdir, "inputs-via-env-context", "push", "", platforms, secrets}, | ||||
| 			{workdir, "do-not-leak-step-env-in-composite", "push", "", platforms, secrets}, | ||||
| 		}...) | ||||
| 	} | ||||
|  | ||||
|   | ||||
							
								
								
									
										17
									
								
								pkg/runner/testdata/do-not-leak-step-env-in-composite/push.yml
									
									
									
									
										vendored
									
									
										Normal file
									
								
							
							
						
						
									
										17
									
								
								pkg/runner/testdata/do-not-leak-step-env-in-composite/push.yml
									
									
									
									
										vendored
									
									
										Normal file
									
								
							| @@ -0,0 +1,17 @@ | ||||
| on: push | ||||
| jobs: | ||||
|   _: | ||||
|     runs-on: ubuntu-latest | ||||
|     steps: | ||||
|     - run: | | ||||
|         runs: | ||||
|           using: composite | ||||
|           steps: | ||||
|           - run: exit 1 | ||||
|             if: env.LEAK_ENV != 'val' | ||||
|       shell: cp {0} action.yml | ||||
|     - uses: ./ | ||||
|       env: | ||||
|         LEAK_ENV: val | ||||
|     - run: exit 1 | ||||
|       if: env.LEAK_ENV == 'val' | ||||
		Reference in New Issue
	
	Block a user