Add super-linter + fix lint issues (#650)

* feat: bump `golangci-lint`, add `super-linter`, replace outdated linter

Bump `golangci-lint` version.
Add `super-linter` to lint other languages.
Go linter is disabled because it's currently broken:
https://github.com/github/super-linter/pull/370
Replacing `scopelint` with `exportloopref`: "[runner] The linter
'scopelint' is deprecated (since v1.39.0) due to: The repository of the
linter has been deprecated by the owner.  Replaced by exportloopref."
Fixed formatting in `.golangci.yml`
Add addtional linters:
  `misspell`: purely style, detects typos in comments
  `whitespace`: detects leading and trailing whitespace
  `goimports`: it's gofmt + checks unused imports

* fix: lint/fix `go` files

* fix: lint with `standardjs`

* fix: lint/fix with `markdownlint`, make template more verbose

* feat: add lint stuff to makefile

* fix: `UseGitIgnore` formatting

* fix: lint/fix `README.md`

Co-authored-by: Casey Lee <cplee@nektos.com>

pkg/common/file.go

@@ -28,7 +28,6 @@ func CopyFile(source string, dest string) (err error) {
 		if err != nil {
 			_ = os.Chmod(dest, sourceinfo.Mode())
 		}
-
 	}
 
 	return
@@ -36,7 +35,6 @@ func CopyFile(source string, dest string) (err error) {
 
 // CopyDir recursive copy of directory
 func CopyDir(source string, dest string) (err error) {
-
 	// get properties of source dir
 	sourceinfo, err := os.Stat(source)
 	if err != nil {
@@ -55,7 +53,6 @@ func CopyDir(source string, dest string) (err error) {
 	objects, err := directory.Readdir(-1)
 
 	for _, obj := range objects {
-
 		sourcefilepointer := source + "/" + obj.Name()
 
 		destinationfilepointer := dest + "/" + obj.Name()
@@ -73,7 +70,6 @@ func CopyDir(source string, dest string) (err error) {
 				fmt.Println(err)
 			}
 		}
-
 	}
 	return err
 }

pkg/common/git.go

@@ -301,7 +301,6 @@ func NewGitCloneExecutor(input NewGitCloneExecutorInput) Executor {
 		// Repos on disk point to commit hashes, and need to checkout input.Ref before
 		// we try and pull down any changes
 		if hash.String() != input.Ref {
-
 			// Run git fetch to make sure we have the latest sha
 			err := r.Fetch(&git.FetchOptions{})
 			if err != nil && !errors.Is(err, git.NoErrAlreadyUpToDate) {

pkg/common/git_test.go

@@ -40,7 +40,6 @@ func TestFindGitSlug(t *testing.T) {
 		assert.Equal(tt.provider, provider)
 		assert.Equal(tt.slug, slug)
 	}
-
 }
 
 func testDir(t *testing.T) string {

pkg/container/docker_build.go

@@ -63,7 +63,6 @@ func NewDockerBuildExecutor(input NewDockerBuildExecutorInput) common.Executor {
 		}
 		return nil
 	}
-
 }
 func createBuildContext(contextDir string, relDockerfile string) (io.ReadCloser, error) {
 	log.Debugf("Creating archive for build context dir '%s' with relative dockerfile '%s'", contextDir, relDockerfile)

pkg/container/docker_pull.go

@@ -62,9 +62,7 @@ func NewDockerPullExecutor(input NewDockerPullExecutorInput) common.Executor {
 			return err
 		}
 		return nil
-
 	}
-
 }
 
 func cleanImage(image string) string {

pkg/container/docker_run.go

@@ -151,7 +151,6 @@ func (cr *containerReference) UpdateFromGithubEnv(env *map[string]string) common
 }
 
 func (cr *containerReference) Exec(command []string, env map[string]string) common.Executor {
-
 	return common.NewPipelineExecutor(
 		cr.connect(),
 		cr.find(),

pkg/model/workflow.go

@@ -23,7 +23,6 @@ type Workflow struct {
 
 // On events for the workflow
 func (w *Workflow) On() []string {
-
 	switch w.RawOn.Kind {
 	case yaml.ScalarNode:
 		var val string
@@ -109,7 +108,6 @@ func (j *Job) Container() *ContainerSpec {
 
 // Needs list for Job
 func (j *Job) Needs() []string {
-
 	switch j.RawNeeds.Kind {
 	case yaml.ScalarNode:
 		var val string
@@ -131,7 +129,6 @@ func (j *Job) Needs() []string {
 
 // RunsOn list for Job
 func (j *Job) RunsOn() []string {
-
 	switch j.RawRunsOn.Kind {
 	case yaml.ScalarNode:
 		var val string
@@ -183,7 +180,6 @@ func (j *Job) GetMatrixes() []map[string]interface{} {
 			log.Debugf("Adding include '%v'", include)
 			matrixes = append(matrixes, include)
 		}
-
 	} else {
 		matrixes = append(matrixes, make(map[string]interface{}))
 	}
@@ -313,12 +309,12 @@ func (s *Step) Type() StepType {
 }
 
 func (s *Step) Validate() error {
-    if s.Type() != StepTypeRun {
-        return fmt.Errorf("(StepID: %s): Unexpected value 'uses'", s.String())
-    } else if s.Shell == "" {
-        return fmt.Errorf("(StepID: %s): Required property is missing: 'shell'", s.String())
-    }
-    return nil
+	if s.Type() != StepTypeRun {
+		return fmt.Errorf("(StepID: %s): Unexpected value 'uses'", s.String())
+	} else if s.Shell == "" {
+		return fmt.Errorf("(StepID: %s): Required property is missing: 'shell'", s.String())
+	}
+	return nil
 }
 
 // ReadWorkflow returns a list of jobs for a given workflow file reader

pkg/runner/expression_test.go

@@ -199,7 +199,6 @@ func updateTestExpressionWorkflow(t *testing.T, tables []struct {
 	in  string
 	out string
 }, rc *RunContext) {
-
 	var envs string
 	keys := make([]string, 0, len(rc.Env))
 	for k := range rc.Env {
@@ -242,7 +241,6 @@ jobs:
 	if err != nil {
 		t.Fatal(err)
 	}
-
 }
 
 func TestRewrite(t *testing.T) {

pkg/runner/logger.go

@@ -109,7 +109,6 @@ func (f *stepLogFormatter) print(b *bytes.Buffer, entry *logrus.Entry) {
 }
 
 func (f *stepLogFormatter) isColored(entry *logrus.Entry) bool {
-
 	isColored := checkIfTerminal(entry.Logger.Out)
 
 	if force, ok := os.LookupEnv("CLICOLOR_FORCE"); ok && force != "0" {

pkg/runner/res/trampoline.js

@@ -1,14 +1,14 @@
 const { spawnSync } = require('child_process')
-const spawnArguments={
-  cwd: process.env['INPUT_CWD'],
+const spawnArguments = {
+  cwd: process.env.INPUT_CWD,
   stdio: [
     process.stdin,
     process.stdout,
-    process.stderr,
+    process.stderr
   ]
 }
-const child=spawnSync(
+const child = spawnSync(
   '/bin/sh',
-  [ '-c' ].concat(process.env['INPUT_COMMAND']),
+  ['-c'].concat(process.env.INPUT_COMMAND),
   spawnArguments)
 process.exit(child.status)

pkg/runner/run_context.go

@@ -336,7 +336,6 @@ func (rc *RunContext) EvalBool(expr string) (bool, error) {
 				!strings.Contains(part, "!")) && // but it's not negated
 				interpolatedPart == "false" && // and the interpolated string is false
 				(isString || previousOrNextPartIsAnOperator(i, parts)) { // and it's of type string or has an logical operator before or after
-
 				interpolatedPart = fmt.Sprintf("'%s'", interpolatedPart) // then we have to quote the false expression
 			}
 

pkg/runner/run_context_test.go

@@ -157,7 +157,6 @@ func updateTestIfWorkflow(t *testing.T, tables []struct {
 	out     bool
 	wantErr bool
 }, rc *RunContext) {
-
 	var envs string
 	keys := make([]string, 0, len(rc.Env))
 	for k := range rc.Env {

pkg/runner/runner.go

@@ -33,7 +33,7 @@ type Config struct {
 	Privileged            bool              // use privileged mode
 	UsernsMode            string            // user namespace to use
 	ContainerArchitecture string            // Desired OS/architecture platform for running containers
-	UseGitIgnore     bool              // controls if paths in .gitignore should not be copied into container, default true
+	UseGitIgnore          bool              // controls if paths in .gitignore should not be copied into container, default true
 }
 
 type runnerImpl struct {

pkg/runner/step_context.go

@@ -539,7 +539,6 @@ func (sc *StepContext) runAction(actionDir string, actionPath string) common.Exe
 				// Interpolate the outer inputs into the composite step with items
 				exprEval := sc.NewExpressionEvaluator()
 				for k, v := range stepContext.Step.With {
-
 					if strings.Contains(v, "inputs") {
 						stepContext.Step.With[k] = exprEval.Interpolate(v)
 					}