diff --git a/sdk/xtdk/rtlfuncs.h b/sdk/xtdk/rtlfuncs.h index 1da539c..fe468a4 100644 --- a/sdk/xtdk/rtlfuncs.h +++ b/sdk/xtdk/rtlfuncs.h @@ -40,11 +40,11 @@ RtlInitializeListHead32(IN PLIST_ENTRY32 ListHead); VOID RtlInsertHeadList(IN OUT PLIST_ENTRY ListHead, - IN OUT PLIST_ENTRY Entry); + IN PLIST_ENTRY Entry); VOID RtlInsertTailList(IN OUT PLIST_ENTRY ListHead, - IN OUT PLIST_ENTRY Entry); + IN PLIST_ENTRY Entry); BOOLEAN RtlListEmpty(PLIST_ENTRY ListHead); @@ -80,9 +80,9 @@ RtlStringLength(IN CONST PUCHAR String, XTCDECL INT -RtlStringToWideString(PWCHAR Destination, - CONST PUCHAR *Source, - SIZE_T Length); +RtlStringToWideString(OUT PWCHAR Destination, + IN CONST PUCHAR *Source, + IN SIZE_T Length); XTCDECL INT @@ -92,9 +92,9 @@ RtlWideStringCompare(IN CONST PWCHAR String1, XTCDECL PWCHAR -RtlWideStringConcatenate(PWCHAR Destination, - PWCHAR Source, - SIZE_T Count); +RtlWideStringConcatenate(OUT PWCHAR Destination, + IN PWCHAR Source, + IN SIZE_T Count); XTCDECL SIZE_T diff --git a/xtldr/amd64/memory.c b/xtldr/amd64/memory.c index 23f58a3..7c42599 100644 --- a/xtldr/amd64/memory.c +++ b/xtldr/amd64/memory.c @@ -73,9 +73,9 @@ BlCreateStack(IN PVOID *StackPtr, */ EFI_STATUS BlEnablePaging(IN PLIST_ENTRY MemoryMappings, - IN PVOID VirtualAddress, - IN PEFI_LOADED_IMAGE_PROTOCOL ImageProtocol, - IN PVOID *PtePointer) + IN PVOID VirtualAddress, + IN PEFI_LOADED_IMAGE_PROTOCOL ImageProtocol, + IN PVOID *PtePointer) { PLOADER_MEMORY_MAPPING Mapping; EFI_PHYSICAL_ADDRESS Address; diff --git a/xtldr/includes/blproto.h b/xtldr/includes/blproto.h index 51cb824..dc4c437 100644 --- a/xtldr/includes/blproto.h +++ b/xtldr/includes/blproto.h @@ -14,7 +14,7 @@ /* Loader protocol routine pointers */ -typedef EFI_STATUS (*PBL_ADD_VIRTUAL_MEMORY_MAPPING)(IN PLIST_ENTRY MemoryMappings, IN PVOID VirtualAddress, IN PVOID PhysicalAddress, IN UINT NumberOfPages, LOADER_MEMORY_TYPE MemoryType); +typedef EFI_STATUS (*PBL_ADD_VIRTUAL_MEMORY_MAPPING)(IN PLIST_ENTRY MemoryMappings, IN PVOID VirtualAddress, IN PVOID PhysicalAddress, IN UINT NumberOfPages, IN LOADER_MEMORY_TYPE MemoryType); typedef EFI_STATUS (*PBL_ALLOCATE_PAGES)(IN UINT64 Size, OUT PEFI_PHYSICAL_ADDRESS Memory); typedef EFI_STATUS (*PBL_ALLOCATE_POOL)(IN UINT_PTR Size, OUT PVOID *Memory); typedef EFI_STATUS (*PBL_ENABLE_PAGING)(IN PLIST_ENTRY MemoryMappings, IN PVOID VirtualAddress, IN PEFI_LOADED_IMAGE_PROTOCOL ImageProtocol, IN PVOID *PtePointer); diff --git a/xtldr/includes/xtbl.h b/xtldr/includes/xtbl.h index 5a8e2e6..d72e539 100644 --- a/xtldr/includes/xtbl.h +++ b/xtldr/includes/xtbl.h @@ -37,7 +37,7 @@ BlAddVirtualMemoryMapping(IN PLIST_ENTRY MemoryMappings, IN PVOID VirtualAddress, IN PVOID PhysicalAddress, IN UINT NumberOfPages, - LOADER_MEMORY_TYPE MemoryType); + IN LOADER_MEMORY_TYPE MemoryType); EFI_STATUS BlCloseVolume(IN PEFI_HANDLE VolumeHandle); diff --git a/xtldr/memory.c b/xtldr/memory.c index 7026718..fd3f577 100644 --- a/xtldr/memory.c +++ b/xtldr/memory.c @@ -36,7 +36,7 @@ BlAddVirtualMemoryMapping(IN PLIST_ENTRY MemoryMappings, IN PVOID VirtualAddress, IN PVOID PhysicalAddress, IN UINT NumberOfPages, - LOADER_MEMORY_TYPE MemoryType) + IN LOADER_MEMORY_TYPE MemoryType) { PLOADER_MEMORY_MAPPING Mapping1, Mapping2, Mapping3; PVOID PhysicalAddressEnd, PhysicalAddress2End; diff --git a/xtldr/modules/dummy/dummy.c b/xtldr/modules/dummy/dummy.c index 9824fc1..f01d86a 100644 --- a/xtldr/modules/dummy/dummy.c +++ b/xtldr/modules/dummy/dummy.c @@ -32,8 +32,8 @@ PXT_BOOT_LOADER_PROTOCOL XtLdrProtocol; * @since XT 1.0 */ EFI_STATUS -BlXtLdrModuleMain(EFI_HANDLE ImageHandle, - PEFI_SYSTEM_TABLE SystemTable) +BlXtLdrModuleMain(IN EFI_HANDLE ImageHandle, + IN PEFI_SYSTEM_TABLE SystemTable) { EFI_STATUS Status; diff --git a/xtldr/modules/xtos/includes/xtos.h b/xtldr/modules/xtos/includes/xtos.h index 7f0b188..477b490 100644 --- a/xtldr/modules/xtos/includes/xtos.h +++ b/xtldr/modules/xtos/includes/xtos.h @@ -35,7 +35,7 @@ XtpLoadModule(IN PEFI_FILE_HANDLE BootDir, OUT PPECOFF_IMAGE_CONTEXT *ImageContext); EFI_STATUS -BlXtLdrModuleMain(EFI_HANDLE ImageHandle, - PEFI_SYSTEM_TABLE SystemTable); +BlXtLdrModuleMain(IN EFI_HANDLE ImageHandle, + IN PEFI_SYSTEM_TABLE SystemTable); #endif /* __XTLDR_MODULES_XTOS_H */ diff --git a/xtoskrnl/rtl/plist.c b/xtoskrnl/rtl/plist.c index d8dd398..6d93dfb 100644 --- a/xtoskrnl/rtl/plist.c +++ b/xtoskrnl/rtl/plist.c @@ -58,7 +58,7 @@ RtlInitializeListHead32(IN PLIST_ENTRY32 ListHead) */ VOID RtlInsertHeadList(IN OUT PLIST_ENTRY ListHead, - IN OUT PLIST_ENTRY Entry) + IN PLIST_ENTRY Entry) { Entry->Flink = ListHead->Flink; Entry->Blink = ListHead; @@ -81,7 +81,7 @@ RtlInsertHeadList(IN OUT PLIST_ENTRY ListHead, */ VOID RtlInsertTailList(IN OUT PLIST_ENTRY ListHead, - IN OUT PLIST_ENTRY Entry) + IN PLIST_ENTRY Entry) { Entry->Flink = ListHead; Entry->Blink = ListHead->Blink; diff --git a/xtoskrnl/rtl/string.c b/xtoskrnl/rtl/string.c index cc4940b..628c1bc 100644 --- a/xtoskrnl/rtl/string.c +++ b/xtoskrnl/rtl/string.c @@ -69,9 +69,9 @@ RtlStringLength(IN CONST PUCHAR String, */ XTCDECL INT -RtlStringToWideString(PWCHAR Destination, - CONST PUCHAR *Source, - SIZE_T Length) +RtlStringToWideString(OUT PWCHAR Destination, + IN CONST PUCHAR *Source, + IN SIZE_T Length) { PUCHAR LocalSource = *Source; SIZE_T Count = Length;