Refactor thread initialization to attach to process

xtoskrnl/includes/ke/kthread.hh

@@ -21,6 +21,7 @@ namespace KE
             STATIC ETHREAD InitialThread;
 
         public:
+            STATIC XTAPI VOID AttachThread(IN PKTHREAD Thread);
             STATIC XTAPI PETHREAD GetInitialThread(VOID);
             STATIC XTAPI XTSTATUS InitializeIdleThread(IN PKPROCESS IdleProcess,
                                                        IN OUT PKTHREAD IdleThread,
@@ -34,8 +35,7 @@ namespace KE
                                                    IN PCONTEXT Context,
                                                    IN PVOID EnvironmentBlock,
                                                    IN PVOID Stack,
-                                                   IN BOOLEAN StartThread);
+                                                   IN BOOLEAN AttachToProcess);
-            STATIC XTAPI VOID StartThread(IN PKTHREAD Thread);
 
         private:
             STATIC XTAPI VOID HandleSystemThreadExit(VOID);

xtoskrnl/ke/kthread.cc

@@ -9,6 +9,72 @@
 #include <xtos.hh>
 
 
+/**
+ * Finalizes thread initialization by inheriting parent process scheduling properties.
+ *
+ * @param Thread
+ *        Supplies a pointer to the thread.
+ *
+ * @return This routine does not return any value.
+ *
+ * @since XT 1.0
+ */
+XTAPI
+VOID
+KE::KThread::AttachThread(IN OUT PKTHREAD Thread)
+{
+    ULONG IdealProcessor;
+    PKPROCESS Process;
+
+    /* Extract the parent process from the thread's initial APC state */
+    Process = Thread->ApcState.Process;
+
+    /* Inherit scheduling properties from the parent process */
+    Thread->DisableBoost = Process->DisableBoost;
+    Thread->Iopl = Process->Iopl;
+    Thread->Quantum = Process->Quantum;
+    Thread->SystemAffinityActive = FALSE;
+
+    /* Acquire the process lock */
+    KE::SpinLockGuard ProcessGuard(&Process->ProcessLock);
+
+    /* Inherit priority from the parent process */
+    Thread->BasePriority = Process->BasePriority;
+    Thread->Priority = Process->BasePriority;
+
+    /* Inherit affinity state from the parent process */
+    KE::Affinity::CopyAffinity(Thread->Affinity, Process->Affinity);
+    KE::Affinity::CopyAffinity(Thread->UserAffinity, Process->Affinity);
+
+    /* Calculate the ideal processor based on the process thread seed and the affinity map */
+    IdealProcessor = KE::Affinity::FindNextRightSetProcessor(Process->ThreadSeed, Thread->Affinity);
+
+    /* Advance the thread seed for the next thread created in this process */
+    Process->ThreadSeed++;
+
+    /* Assign the selected ideal processor */
+    Thread->IdealProcessor = (UCHAR)IdealProcessor;
+    Thread->UserIdealProcessor = (UCHAR)IdealProcessor;
+
+    /* Acquire the dispatcher database lock */
+    KE::QueuedSpinLockGuard DispatcherGuard(DispatcherLock);
+
+    /* Insert the thread into the process's active thread list */
+    RTL::LinkedList::InsertTailList(&Process->ThreadListHead, &Thread->ThreadListEntry);
+
+    /* Handle edge cases where the stack count is uninitialized or explicitly maxed out */
+    if(Process->StackCount == MAXULONG_PTR)
+    {
+        /* Initialize the stack count for the first thread */
+        Process->StackCount = 1;
+    }
+    else
+    {
+        /* Increment the process stack count */
+        Process->StackCount++;
+    }
+}
+
 /**
  * Retrieves a pointer to the system's initial executive thread object.
  *
@@ -149,7 +215,7 @@ KE::KThread::InitializeThread(IN PKPROCESS Process,
                               IN PCONTEXT Context,
                               IN PVOID EnvironmentBlock,
                               IN PVOID Stack,
-                              IN BOOLEAN RunThread)
+                              IN BOOLEAN AttachToProcess)
 {
     PKWAIT_BLOCK TimerWaitBlock;
     BOOLEAN Allocation;
@@ -270,33 +336,16 @@ KE::KThread::InitializeThread(IN PKPROCESS Process,
     Thread->State = Initialized;
 
     /* Check if thread should be started */
-    if(RunThread)
+    if(AttachToProcess)
     {
         /* Start thread */
-        StartThread(Thread);
+        AttachThread(Thread);
     }
 
     /* Return success */
     return STATUS_SUCCESS;
 }
 
-/**
- * Starts the thread.
- *
- * @param Thread
- *        Supplies a pointer to the thread.
- *
- * @return This routine does not return any value.
- *
- * @since XT 1.0
- */
-XTAPI
-VOID
-KE::KThread::StartThread(IN OUT PKTHREAD Thread)
-{
-    UNIMPLEMENTED;
-}
-
 /**
  * Suspend APC-built thread NOP routine. It takes no actions.
  *
@@ -383,4 +432,5 @@ XTAPI
 VOID
 KE::KThread::SwitchToUserMode(VOID)
 {
+    UNIMPLEMENTED;
 }