From 032cab7f2f7e7778255525d2991b391a3f93fe52 Mon Sep 17 00:00:00 2001
From: Aiken Harris <harraiken91@gmail.com>
Date: Mon, 12 Jan 2026 19:26:07 +0100
Subject: [PATCH] Update function documentation and remove debug prints

---
 boot/xtldr/modules/xtos_o/xtos.cc | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/boot/xtldr/modules/xtos_o/xtos.cc b/boot/xtldr/modules/xtos_o/xtos.cc
index 57d943b..1d95823 100644
--- a/boot/xtldr/modules/xtos_o/xtos.cc
+++ b/boot/xtldr/modules/xtos_o/xtos.cc
@@ -232,7 +232,6 @@ Xtos::GetMemoryDescriptorList(IN PXTBL_PAGE_MAPPING PageMap,
         ListEntry = ListEntry->Flink;
     }
 
-    XtLdrProtocol->Debug.Print(L"Address: %llX, Pages: %llu\n", (ULONGLONG)PhysicalBase, Pages);
     PhysicalListToVirtual(MemoryDescriptorList);
 
     return STATUS_EFI_SUCCESS;
@@ -388,11 +387,14 @@ Xtos::InitializeApicBase(IN PXTBL_PAGE_MAPPING PageMap)
 /**
  * Initializes and maps the kernel initialization block.
  *
- * @param MemoryMappings
- *        Supplies a pointer to linked list containing all memory mappings.
+ * @param PageMap
+ *        Supplies a pointer to the page map.
  *
- * @param VirtualAddress
- *        Supplies a pointer to the next valid, free and available virtual address.
+ * @param KernelParameters
+ *        Returns a pointer to the kernel initialization block.
+ *
+ * @param Parameters
+ *        Supplies a list of input parameters passed to the kernel.
  *
  * @return This routine returns a status code.
  *
@@ -505,12 +507,12 @@ Xtos::InitializeModule(IN EFI_HANDLE ImageHandle,
  * @param FileName
  *        An on disk filename of the module that will be loaded.
  *
- * @param VirtualAddress
- *        Optional virtual address pointing to the memory area where PE/COFF file will be loaded.
- *
  * @param MemoryType
  *        Supplies the type of memory to be assigned to the memory descriptor.
  *
+ * @param PageMap
+ *        Supplies pointer to the memory area where memory mappings will be stored.
+ *
  * @param ImageContext
  *        Supplies pointer to the memory area where loaded PE/COFF image context will be stored.
  *
@@ -596,7 +598,7 @@ Xtos::LoadModule(IN PEFI_FILE_HANDLE SystemDir,
 
     /* Print debug message */
     XtLdrProtocol->Debug.Print(L"Loaded '%S' at PA: %P, VA: %P\n", FileName, (*ImageContext)->PhysicalAddress,
-                               KSEG0_BASE + (ULONGLONG)(*ImageContext)->VirtualAddress);
+                               PhysicalAddressToVirtual((*ImageContext)->VirtualAddress));
 
     /* Return success */
     return STATUS_EFI_SUCCESS;