xt-sys/exectos
3
5
Fork 2
Code Issues 4 Pull Requests Actions Projects 1 Releases Wiki Activity

Implement resource cleanup for failed allocations during idle thread setup
All checks were successful
Builds / ExectOS (i686, debug) (push) Successful in 45s
Details
Builds / ExectOS (amd64, release) (push) Successful in 47s
Details
Builds / ExectOS (amd64, debug) (push) Successful in 47s
Details
Builds / ExectOS (i686, release) (push) Successful in 45s
Details

Browse Source
This commit is contained in:
Aiken Harris
2026-06-04 14:36:43 +02:00
parent 53a239958f
commit f680830b53
3 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
xtoskrnl/ke/kprocess.cc
View File

@@ -82,7 +82,8 @@ KE::KProcess::InitializeIdleProcess(IN OUT PKPROCESS Process,
Status = MM::Allocator::AllocatePool(NonPagedPool, MapSize, (PVOID*)&Process->ActiveProcessors); Status = MM::Allocator::AllocatePool(NonPagedPool, MapSize, (PVOID*)&Process->ActiveProcessors);
if(Status != STATUS_SUCCESS) if(Status != STATUS_SUCCESS)
{ {
/* Memory allocation failed, return the status code */ /* Memory allocation failed, free previously allocated memory and return the status code */
MM::Allocator::FreePool((PVOID)Process->Affinity);
return Status; return Status;
} }

7
xtoskrnl/ke/kthread.cc
View File

@@ -75,7 +75,8 @@ KE::KThread::InitializeIdleThread(IN PKPROCESS IdleProcess,
Status = MM::Allocator::AllocatePool(NonPagedPool, MapSize, (PVOID*)&IdleThread->UserAffinity); Status = MM::Allocator::AllocatePool(NonPagedPool, MapSize, (PVOID*)&IdleThread->UserAffinity);
if(Status != STATUS_SUCCESS) if(Status != STATUS_SUCCESS)
{ {
/* Memory allocation failed, return the status code */ /* Memory allocation failed, free previously allocated memory and return the status code */
MM::Allocator::FreePool((PVOID)IdleThread->Affinity);
return Status; return Status;
} }
@@ -88,7 +89,9 @@ KE::KThread::InitializeIdleThread(IN PKPROCESS IdleProcess,
NULLPTR, NULLPTR, Stack, TRUE); NULLPTR, NULLPTR, Stack, TRUE);
if(Status != STATUS_SUCCESS) if(Status != STATUS_SUCCESS)
{ {
/* Failed to initialize IDLE thread, return status code */ /* Failed to initialize IDLE thread, free both affinity maps and return the status code */
MM::Allocator::FreePool((PVOID)IdleThread->Affinity);
MM::Allocator::FreePool((PVOID)IdleThread->UserAffinity);
return Status; return Status;
} }

11
xtoskrnl/ps/thread.cc
View File

@@ -50,5 +50,14 @@ PS::Thread::CreateIdleThread(IN PKPROCESSOR_CONTROL_BLOCK Prcb,
Prcb->IdleThread = &IdleThread->ThreadControlBlock; Prcb->IdleThread = &IdleThread->ThreadControlBlock;
/* Initialize the IDLE thread */ /* Initialize the IDLE thread */
return KE::KThread::InitializeIdleThread(IdleProcess, &IdleThread->ThreadControlBlock, Prcb, Stack); Status = KE::KThread::InitializeIdleThread(IdleProcess, &IdleThread->ThreadControlBlock, Prcb, Stack);
if(Status != STATUS_SUCCESS)
{
/* Failed to initialize the IDLE thread state, free the ETHREAD object and return the status code */
MM::Allocator::FreePool((PVOID)IdleThread);
return Status;
}
/* Return success */
return STATUS_SUCCESS;
} }