#17 Include(_once) & require(_once) looks for included files in wrong directory, depending on CWD

Closed
opened 2 years ago by belliash · 7 comments
belliash commented 2 years ago
Owner

Aer Information

  • Aer Version (or commit ref): 4c81475afb
  • Operating System: Linux
  • System Architecture (eg. arm, x86_64, ...): x86_64

Your problem description

When relative path is passed as argument to include alike function, it looks for source file in current directory (.). When first source file is opened, it should change working directory to it. This way, script will behave in the same way, independent on CWD.

Example directory structure:

~/
~/binary
~/binary/psharp
~/test.php
~/a.php

test.php:

<?php
    require_once 'a.php';
?>

a.php:

<?php
    echo 'Hello World';
?>

If our current working directory (CWD) is ~/binary and we call ./psharp ../test.php it will not find a.php. However, if we change directory to ~ and call ./binary/psharp test.php it will work just fine.

<!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please take a moment to check that your issue doesn't already exist. 3. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> # Aer Information - Aer Version (or commit ref): 4c81475afb - Operating System: Linux - System Architecture (eg. arm, x86_64, ...): x86_64 # Your problem description When relative path is passed as argument to include alike function, it looks for source file in current directory (.). When first source file is opened, it should change working directory to it. This way, script will behave in the same way, independent on CWD. Example directory structure: ~/ ~/binary ~/binary/psharp ~/test.php ~/a.php test.php: <?php require_once 'a.php'; ?> a.php: <?php echo 'Hello World'; ?> If our current working directory (CWD) is ~/binary and we call ./psharp ../test.php it will not find a.php. However, if we change directory to ~ and call ./binary/psharp test.php it will work just fine.
belliash added the
bug
label 2 years ago
belliash commented 2 years ago
Poster
Owner

IMHO, Aer Interpreter should change CWD to directory containing entry file.

IMHO, Aer Interpreter should change CWD to directory containing entry file.
devnexen commented 2 years ago
Poster
Collaborator

hopefully #16 fix ought to fix it too.

hopefully #16 fix ought to fix it too.
belliash commented 2 years ago
Poster
Owner

Unfortunately not.
What is more, require_once & include_once stopped working.

Unfortunately not. What is more, require_once & include_once stopped working.
devnexen commented 2 years ago
Poster
Collaborator

Hopefully it does now :)

Hopefully it does now :)
belliash commented 2 years ago
Poster
Owner

Yes, functions are working again, however this ticket is not resolved yet.
File inclusion depends on CWD and I believe we have to chdir to realpath of entry file.

Yes, functions are working again, however this ticket is not resolved yet. File inclusion depends on CWD and I believe we have to chdir to realpath of entry file.
devnexen closed this issue 2 years ago
belliash reopened this issue 2 years ago
belliash commented 2 years ago
Poster
Owner

This is still not working. In 3ed00e610f, I have fixed the PH7_VM_CONFIG_IMPORT_PATH mechanism. Actually, we just need to get the absolute path of entry file, then obtain realpath and register it into import path.

This is still not working. In 3ed00e610f, I have fixed the PH7_VM_CONFIG_IMPORT_PATH mechanism. Actually, we just need to get the absolute path of entry file, then obtain realpath and register it into import path.
belliash self-assigned this 2 years ago
belliash commented 2 years ago
Poster
Owner

I will take care.

I will take care.
belliash closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.