Include(_once) & require(_once) looks for included files in wrong directory, depending on CWD #17

닫힘
" belliash2018-07-22 16:57:43 +02:00을 오픈" · 7개의 코멘트
소유자

Aer Information

  • Aer Version (or commit ref): 4c81475afb
  • Operating System: Linux
  • System Architecture (eg. arm, x86_64, ...): x86_64

Your problem description

When relative path is passed as argument to include alike function, it looks for source file in current directory (.). When first source file is opened, it should change working directory to it. This way, script will behave in the same way, independent on CWD.

Example directory structure:

~/
~/binary
~/binary/psharp
~/test.php
~/a.php

test.php:

<?php
    require_once 'a.php';
?>

a.php:

<?php
    echo 'Hello World';
?>

If our current working directory (CWD) is ~/binary and we call ./psharp ../test.php it will not find a.php. However, if we change directory to ~ and call ./binary/psharp test.php it will work just fine.

<!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please take a moment to check that your issue doesn't already exist. 3. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> # Aer Information - Aer Version (or commit ref): 4c81475afb - Operating System: Linux - System Architecture (eg. arm, x86_64, ...): x86_64 # Your problem description When relative path is passed as argument to include alike function, it looks for source file in current directory (.). When first source file is opened, it should change working directory to it. This way, script will behave in the same way, independent on CWD. Example directory structure: ~/ ~/binary ~/binary/psharp ~/test.php ~/a.php test.php: <?php require_once 'a.php'; ?> a.php: <?php echo 'Hello World'; ?> If our current working directory (CWD) is ~/binary and we call ./psharp ../test.php it will not find a.php. However, if we change directory to ~ and call ./binary/psharp test.php it will work just fine.
belliash added the
bug
label 2018-07-22 16:57:43 +02:00
Author
소유자

IMHO, Aer Interpreter should change CWD to directory containing entry file.

IMHO, Aer Interpreter should change CWD to directory containing entry file.
멤버

hopefully #16 fix ought to fix it too.

hopefully #16 fix ought to fix it too.
Author
소유자

Unfortunately not.
What is more, require_once & include_once stopped working.

Unfortunately not. What is more, require_once & include_once stopped working.
멤버

Hopefully it does now :)

Hopefully it does now :)
Author
소유자

Yes, functions are working again, however this ticket is not resolved yet.
File inclusion depends on CWD and I believe we have to chdir to realpath of entry file.

Yes, functions are working again, however this ticket is not resolved yet. File inclusion depends on CWD and I believe we have to chdir to realpath of entry file.
belliash reopened this issue 2018-07-23 19:47:20 +02:00
Author
소유자

This is still not working. In 3ed00e610f, I have fixed the PH7_VM_CONFIG_IMPORT_PATH mechanism. Actually, we just need to get the absolute path of entry file, then obtain realpath and register it into import path.

This is still not working. In 3ed00e610f, I have fixed the PH7_VM_CONFIG_IMPORT_PATH mechanism. Actually, we just need to get the absolute path of entry file, then obtain realpath and register it into import path.
belliash 자체적으로 할당됨 2018-07-23 22:19:38 +02:00
Author
소유자

I will take care.

I will take care.
"로그인하여 이 대화에 참여"
마일스톤 없음
담당자 없음
참여자 2명
알림
마감일
기한이 올바르지 않거나 범위를 벗어났습니다. 'yyyy-mm-dd'형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: aerscript/Aer#17
No description provided.