aerscript/Aer

포크 0

Include(_once) & require(_once) looks for included files in wrong directory, depending on CWD #17

새로운 이슈

닫힘

" belliash가 2018-07-22 16:57:43 +02:00을 오픈" · 7개의 코멘트

belliash 코멘트됨,

2018-07-22 16:57:43 +02:00

소유자

Aer Information

Aer Version (or commit ref): 4c81475afb
Operating System: Linux
System Architecture (eg. arm, x86_64, ...): x86_64

Your problem description

When relative path is passed as argument to include alike function, it looks for source file in current directory (.). When first source file is opened, it should change working directory to it. This way, script will behave in the same way, independent on CWD.

Example directory structure:

~/
~/binary
~/binary/psharp
~/test.php
~/a.php

test.php:

<?php
    require_once 'a.php';
?>

a.php:

<?php
    echo 'Hello World';
?>

If our current working directory (CWD) is ~/binary and we call ./psharp ../test.php it will not find a.php. However, if we change directory to ~ and call ./binary/psharp test.php it will work just fine.

# Aer Information - Aer Version (or commit ref): 4c81475afb - Operating System: Linux - System Architecture (eg. arm, x86_64, ...): x86_64 # Your problem description When relative path is passed as argument to include alike function, it looks for source file in current directory (.). When first source file is opened, it should change working directory to it. This way, script will behave in the same way, independent on CWD. Example directory structure: ~/ ~/binary ~/binary/psharp ~/test.php ~/a.php test.php: <?php require_once 'a.php'; ?> a.php: <?php echo 'Hello World'; ?> If our current working directory (CWD) is ~/binary and we call ./psharp ../test.php it will not find a.php. However, if we change directory to ~ and call ./binary/psharp test.php it will work just fine.

belliash added the

bug

label 2018-07-22 16:57:43 +02:00

belliash 코멘트됨,

2018-07-22 17:00:25 +02:00

Author

소유자

IMHO, Aer Interpreter should change CWD to directory containing entry file.

devnexen 코멘트됨,

2018-07-22 22:59:15 +02:00

멤버

hopefully #16 fix ought to fix it too.

belliash 코멘트됨,

2018-07-23 07:21:14 +02:00

Author

소유자

Unfortunately not.
What is more, require_once & include_once stopped working.

Unfortunately not. What is more, require_once & include_once stopped working.

devnexen 코멘트됨,

2018-07-23 10:56:19 +02:00

멤버

Hopefully it does now :)

belliash 코멘트됨,

2018-07-23 11:00:47 +02:00

Author

소유자

Yes, functions are working again, however this ticket is not resolved yet.
File inclusion depends on CWD and I believe we have to chdir to realpath of entry file.

Yes, functions are working again, however this ticket is not resolved yet. File inclusion depends on CWD and I believe we have to chdir to realpath of entry file.

👍 1

devnexen 커밋

2018-07-23 15:03:46 +02:00

에서 이 이슈 언급

Fix #17 attempt : include/require load full paths in all cases.

devnexen closed this issue

2018-07-23 15:03:46 +02:00

devnexen 커밋

2018-07-23 16:37:51 +02:00

에서 이 이슈 언급

Fix #17 attempt : include/require load full paths in all cases.

belliash reopened this issue

2018-07-23 19:47:20 +02:00

belliash 코멘트됨,

2018-07-23 19:49:14 +02:00

Author

소유자

This is still not working. In 3ed00e610f, I have fixed the PH7_VM_CONFIG_IMPORT_PATH mechanism. Actually, we just need to get the absolute path of entry file, then obtain realpath and register it into import path.

This is still not working. In 3ed00e610f, I have fixed the PH7_VM_CONFIG_IMPORT_PATH mechanism. Actually, we just need to get the absolute path of entry file, then obtain realpath and register it into import path.

belliash 자체적으로 할당됨 2018-07-23 22:19:38 +02:00

belliash 코멘트됨,

2018-07-23 22:19:50 +02:00

Author

소유자

I will take care.

belliash 커밋

2018-07-24 08:06:22 +02:00

에서 이 이슈 언급

Add scripts directory to the include path. This fixes #17.

belliash closed this issue

2018-07-24 08:06:22 +02:00