Further change for module load #11

Merged

belliash merged 1 commits from module_load_fix into master 2018-08-01 16:18:03 +02:00

Conversation 3 Commits 1 Files Changed 1 +3 -1

devnexen commented 2018-07-19 14:42:37 +02:00

Member

Copy Link

No description provided.

belliash commented 2018-07-19 15:17:52 +02:00

Owner

Copy Link

255 bytes a probably enough for absolute path, but why limit this?

255 bytes a probably enough for absolute path, but why limit this?

devnexen commented 2018-07-19 15:31:12 +02:00

Author

Member

Copy Link

We can use PATH_MAX if you wish or hardcode 1024 ... The original code the string is not correct C string, ought to be visible from within gdb or even compiler sanitizer.

We can use PATH_MAX if you wish or hardcode 1024 ... The original code the string is not correct C string, ought to be visible from within gdb or even compiler sanitizer.

devnexen commented 2018-07-19 15:35:04 +02:00

Author

Member

Copy Link

Just tried with asan.

Just tried with asan.

Screenshot_2018-07-19_14-33-36.png

0 B

belliash closed this pull request 2018-07-19 16:51:33 +02:00

belliash deleted branch module_load_fix 2018-07-19 16:51:37 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

aerscript

Changes related to Aer specification

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

idea

This is an idea

question

More information is needed

won't fix

This won't be fixed

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

belliash devnexen

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: aerscript/Aer#11

No description provided.