String comparison routines can return -1 and thus their return type cant be unsigned

sdk/xtdk/rtlfuncs.h

@@ -59,28 +59,28 @@ RtlCompareMemory(IN PCVOID LeftBuffer,
 
 XTCLINK
 XTAPI
-SIZE_T
+LONG
 RtlCompareString(IN PCSTR String1,
                  IN PCSTR String2,
                  IN SIZE_T Length);
 
 XTCLINK
 XTAPI
-SIZE_T
+LONG
 RtlCompareStringInsensitive(IN PCSTR String1,
                             IN PCSTR String2,
                             IN SIZE_T Length);
 
 XTCLINK
 XTAPI
-SIZE_T
+LONG
 RtlCompareWideString(IN PCWSTR String1,
                      IN PCWSTR String2,
                      IN SIZE_T Length);
 
 XTCLINK
 XTAPI
-SIZE_T
+LONG
 RtlCompareWideStringInsensitive(IN PCWSTR String1,
                                 IN PCWSTR String2,
                                 IN SIZE_T Length);

xtoskrnl/includes/rtl/string.hh

@@ -18,12 +18,12 @@ namespace RTL
     class String
     {
         public:
-            STATIC XTAPI SIZE_T CompareString(IN PCSTR String1,
-                                              IN PCSTR String2,
-                                              IN SIZE_T Length);
-            STATIC XTAPI SIZE_T CompareStringInsensitive(IN PCSTR String1,
-                                                         IN PCSTR String2,
-                                                         IN SIZE_T Length);
+            STATIC XTAPI LONG CompareString(IN PCSTR String1,
+                                            IN PCSTR String2,
+                                            IN SIZE_T Length);
+            STATIC XTAPI LONG CompareStringInsensitive(IN PCSTR String1,
+                                                       IN PCSTR String2,
+                                                       IN SIZE_T Length);
             STATIC XTAPI PCHAR ConcatenateString(OUT PCHAR Destination,
                                                  IN PCHAR Source,
                                                  IN SIZE_T Count);

xtoskrnl/includes/rtl/widestr.hh

@@ -18,12 +18,12 @@ namespace RTL
     class WideString
     {
         public:
-            STATIC XTAPI SIZE_T CompareWideString(IN PCWSTR String1,
-                                                  IN PCWSTR String2,
-                                                  IN SIZE_T Length);
-            STATIC XTAPI SIZE_T CompareWideStringInsensitive(IN PCWSTR String1,
-                                                             IN PCWSTR String2,
-                                                             IN SIZE_T Length);
+            STATIC XTAPI LONG CompareWideString(IN PCWSTR String1,
+                                                IN PCWSTR String2,
+                                                IN SIZE_T Length);
+            STATIC XTAPI LONG CompareWideStringInsensitive(IN PCWSTR String1,
+                                                           IN PCWSTR String2,
+                                                           IN SIZE_T Length);
             STATIC XTAPI PWCHAR ConcatenateWideString(OUT PWCHAR Destination,
                                                       IN PWCHAR Source,
                                                       IN SIZE_T Count);

xtoskrnl/rtl/exports.cc

@@ -166,7 +166,7 @@ RtlCompareMemory(IN PCVOID LeftBuffer,
  */
 XTCLINK
 XTAPI
-SIZE_T
+LONG
 RtlCompareString(IN PCSTR String1,
                  IN PCSTR String2,
                  IN SIZE_T Length)
@@ -192,7 +192,7 @@ RtlCompareString(IN PCSTR String1,
  */
 XTCLINK
 XTAPI
-SIZE_T
+LONG
 RtlCompareStringInsensitive(IN PCSTR String1,
                             IN PCSTR String2,
                             IN SIZE_T Length)
@@ -218,7 +218,7 @@ RtlCompareStringInsensitive(IN PCSTR String1,
  */
 XTCLINK
 XTAPI
-SIZE_T
+LONG
 RtlCompareWideString(IN PCWSTR String1,
                      IN PCWSTR String2,
                      IN SIZE_T Length)
@@ -244,7 +244,7 @@ RtlCompareWideString(IN PCWSTR String1,
  */
 XTCLINK
 XTAPI
-SIZE_T
+LONG
 RtlCompareWideStringInsensitive(IN PCWSTR String1,
                                 IN PCWSTR String2,
                                 IN SIZE_T Length)

xtoskrnl/rtl/string.cc

@@ -26,7 +26,7 @@
  * @since XT 1.0
  */
 XTAPI
-SIZE_T
+LONG
 RTL::String::CompareString(IN PCSTR String1,
                            IN PCSTR String2,
                            IN SIZE_T Length)
@@ -78,7 +78,7 @@ RTL::String::CompareString(IN PCSTR String1,
  * @since XT 1.0
  */
 XTAPI
-SIZE_T
+LONG
 RTL::String::CompareStringInsensitive(IN PCSTR String1,
                                       IN PCSTR String2,
                                       IN SIZE_T Length)

xtoskrnl/rtl/widestr.cc

@@ -26,7 +26,7 @@
  * @since XT 1.0
  */
 XTAPI
-SIZE_T
+LONG
 RTL::WideString::CompareWideString(IN PCWSTR String1,
                                    IN PCWSTR String2,
                                    IN SIZE_T Length)
@@ -78,7 +78,7 @@ RTL::WideString::CompareWideString(IN PCWSTR String1,
  * @since XT 1.0
  */
 XTAPI
-SIZE_T
+LONG
 RTL::WideString::CompareWideStringInsensitive(IN PCWSTR String1,
                                               IN PCWSTR String2,
                                               IN SIZE_T Length)