xt-sys/exectos
3
5
Fork 2
Code Issues 5 Pull Requests Actions Projects 1 Releases Wiki Activity

String comparison routines can return -1 and thus their return type cant be unsigned
Some checks failed
Builds / ExectOS (amd64, debug) (push) Failing after 2m2s
Details
Builds / ExectOS (amd64, release) (push) Failing after 1m59s
Details
Builds / ExectOS (i686, release) (push) Failing after 34s
Details
Builds / ExectOS (i686, debug) (push) Failing after 35s
Details

Browse Source
This commit is contained in:
Rafal Kupiec
2026-07-28 18:46:03 +02:00
parent 06ec2bc189
commit 4f79c12e53
6 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sdk/xtdk/rtlfuncs.h
View File

@@ -59,28 +59,28 @@ RtlCompareMemory(IN PCVOID LeftBuffer,
XTCLINK XTCLINK
XTAPI XTAPI
SIZE_T LONG
RtlCompareString(IN PCSTR String1, RtlCompareString(IN PCSTR String1,
IN PCSTR String2, IN PCSTR String2,
IN SIZE_T Length); IN SIZE_T Length);
XTCLINK XTCLINK
XTAPI XTAPI
SIZE_T LONG
RtlCompareStringInsensitive(IN PCSTR String1, RtlCompareStringInsensitive(IN PCSTR String1,
IN PCSTR String2, IN PCSTR String2,
IN SIZE_T Length); IN SIZE_T Length);
XTCLINK XTCLINK
XTAPI XTAPI
SIZE_T LONG
RtlCompareWideString(IN PCWSTR String1, RtlCompareWideString(IN PCWSTR String1,
IN PCWSTR String2, IN PCWSTR String2,
IN SIZE_T Length); IN SIZE_T Length);
XTCLINK XTCLINK
XTAPI XTAPI
SIZE_T LONG
RtlCompareWideStringInsensitive(IN PCWSTR String1, RtlCompareWideStringInsensitive(IN PCWSTR String1,
IN PCWSTR String2, IN PCWSTR String2,
IN SIZE_T Length); IN SIZE_T Length);

12
xtoskrnl/includes/rtl/string.hh
View File

@@ -18,12 +18,12 @@ namespace RTL
class String class String
{ {
public: public:
STATIC XTAPI SIZE_T CompareString(IN PCSTR String1, STATIC XTAPI LONG CompareString(IN PCSTR String1,
IN PCSTR String2, IN PCSTR String2,
IN SIZE_T Length); IN SIZE_T Length);
STATIC XTAPI SIZE_T CompareStringInsensitive(IN PCSTR String1, STATIC XTAPI LONG CompareStringInsensitive(IN PCSTR String1,
IN PCSTR String2, IN PCSTR String2,
IN SIZE_T Length); IN SIZE_T Length);
STATIC XTAPI PCHAR ConcatenateString(OUT PCHAR Destination, STATIC XTAPI PCHAR ConcatenateString(OUT PCHAR Destination,
IN PCHAR Source, IN PCHAR Source,
IN SIZE_T Count); IN SIZE_T Count);

12
xtoskrnl/includes/rtl/widestr.hh
View File

@@ -18,12 +18,12 @@ namespace RTL
class WideString class WideString
{ {
public: public:
STATIC XTAPI SIZE_T CompareWideString(IN PCWSTR String1, STATIC XTAPI LONG CompareWideString(IN PCWSTR String1,
IN PCWSTR String2, IN PCWSTR String2,
IN SIZE_T Length); IN SIZE_T Length);
STATIC XTAPI SIZE_T CompareWideStringInsensitive(IN PCWSTR String1, STATIC XTAPI LONG CompareWideStringInsensitive(IN PCWSTR String1,
IN PCWSTR String2, IN PCWSTR String2,
IN SIZE_T Length); IN SIZE_T Length);
STATIC XTAPI PWCHAR ConcatenateWideString(OUT PWCHAR Destination, STATIC XTAPI PWCHAR ConcatenateWideString(OUT PWCHAR Destination,
IN PWCHAR Source, IN PWCHAR Source,
IN SIZE_T Count); IN SIZE_T Count);

8
xtoskrnl/rtl/exports.cc
View File

@@ -166,7 +166,7 @@ RtlCompareMemory(IN PCVOID LeftBuffer,
*/ */
XTCLINK XTCLINK
XTAPI XTAPI
SIZE_T LONG
RtlCompareString(IN PCSTR String1, RtlCompareString(IN PCSTR String1,
IN PCSTR String2, IN PCSTR String2,
IN SIZE_T Length) IN SIZE_T Length)
@@ -192,7 +192,7 @@ RtlCompareString(IN PCSTR String1,
*/ */
XTCLINK XTCLINK
XTAPI XTAPI
SIZE_T LONG
RtlCompareStringInsensitive(IN PCSTR String1, RtlCompareStringInsensitive(IN PCSTR String1,
IN PCSTR String2, IN PCSTR String2,
IN SIZE_T Length) IN SIZE_T Length)
@@ -218,7 +218,7 @@ RtlCompareStringInsensitive(IN PCSTR String1,
*/ */
XTCLINK XTCLINK
XTAPI XTAPI
SIZE_T LONG
RtlCompareWideString(IN PCWSTR String1, RtlCompareWideString(IN PCWSTR String1,
IN PCWSTR String2, IN PCWSTR String2,
IN SIZE_T Length) IN SIZE_T Length)
@@ -244,7 +244,7 @@ RtlCompareWideString(IN PCWSTR String1,
*/ */
XTCLINK XTCLINK
XTAPI XTAPI
SIZE_T LONG
RtlCompareWideStringInsensitive(IN PCWSTR String1, RtlCompareWideStringInsensitive(IN PCWSTR String1,
IN PCWSTR String2, IN PCWSTR String2,
IN SIZE_T Length) IN SIZE_T Length)

4
xtoskrnl/rtl/string.cc
View File

@@ -26,7 +26,7 @@
* @since XT 1.0 * @since XT 1.0
*/ */
XTAPI XTAPI
SIZE_T LONG
RTL::String::CompareString(IN PCSTR String1, RTL::String::CompareString(IN PCSTR String1,
IN PCSTR String2, IN PCSTR String2,
IN SIZE_T Length) IN SIZE_T Length)
@@ -78,7 +78,7 @@ RTL::String::CompareString(IN PCSTR String1,
* @since XT 1.0 * @since XT 1.0
*/ */
XTAPI XTAPI
SIZE_T LONG
RTL::String::CompareStringInsensitive(IN PCSTR String1, RTL::String::CompareStringInsensitive(IN PCSTR String1,
IN PCSTR String2, IN PCSTR String2,
IN SIZE_T Length) IN SIZE_T Length)

4
xtoskrnl/rtl/widestr.cc
View File

@@ -26,7 +26,7 @@
* @since XT 1.0 * @since XT 1.0
*/ */
XTAPI XTAPI
SIZE_T LONG
RTL::WideString::CompareWideString(IN PCWSTR String1, RTL::WideString::CompareWideString(IN PCWSTR String1,
IN PCWSTR String2, IN PCWSTR String2,
IN SIZE_T Length) IN SIZE_T Length)
@@ -78,7 +78,7 @@ RTL::WideString::CompareWideString(IN PCWSTR String1,
* @since XT 1.0 * @since XT 1.0
*/ */
XTAPI XTAPI
SIZE_T LONG
RTL::WideString::CompareWideStringInsensitive(IN PCWSTR String1, RTL::WideString::CompareWideStringInsensitive(IN PCWSTR String1,
IN PCWSTR String2, IN PCWSTR String2,
IN SIZE_T Length) IN SIZE_T Length)