Add support for x64 EFI on WHPX #18
Reference in New Issue
Block a user
No description provided.
Delete Branch "perikiyoxd/exectos:whpx"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Purpose
Add WHPX support on Windows and introduce OVMF Pure EFI firmware.
Proposed changes
testkvmtarget for Windows using WHPX + OVMF.testkvmtarget for non-Windows (KVM).OVMF-pure-efi.fdfirmware file.TODO
Agreements
Thanks for the contribution. Overall, the changes look good and head in the right direction, but I do have a couple of remarks before we can proceed with the merge.
First, the code is currently outdated and needs to be brought in sync with the latest changes on the master branch. Please rebase or merge from master to resolve any potential conflicts and avoid future regressions.
Second, the QEMU parameters for WHPX are quite minimal. While that is not necessarily a problem right now, I am planning to make further improvements in that area shortly. Because of that, I would prefer to get this merged sooner rather than later. I am not expecting major changes on your side beyond the rebase and cleanup, and I will handle the rest in follow-up work.
Lastly, please make sure your GIT setup follows our contribution guidelines as described at https://exectos.eu.org/contributing/working-with-git/ Specifically, the commits should be made using your real name and valid email address.
Once that is done, I will go ahead and merge this PR.
Please rebase or merge from master.
84402a1db4to356c221e23356c221e23toe5611d8081Done
Ive noticed more things:
I don't know how to reliably obtain OVMF images, as I used what was provided to me for a specific use case (x64 EFI on WHPX).
Add support for WHPX accelerator on Windows and introduce OVMF Pure EFI firmwareto Add support for x64 EFI on WHPXDo you see any of these points as blockers for merging the current changes? I would really prefer not to let this work go to waste, especially since I am planning to improve this area further anyway.
Since there has not been any further feedback, I am assuming silent approval and merging this.