Use PowerShell module and improved xtchain ps1 #11

Closed

perikiyoxd wants to merge 1 commits from perikiyoxd/xtchain:next-powershell-module into master

perikiyoxd commented

2025-09-26 13:59:12 +02:00

First-time contributor

Reworked the xtclib.ps1 to be a module instead (xtclib.psm1), and a quick rework of the xtchain.ps1 to follow coding guidelines for PowerShell

Reworked the `xtclib.ps1` to be a module instead (`xtclib.psm1`), and a quick rework of the `xtchain.ps1` to follow coding guidelines for PowerShell

perikiyoxd added 1 commit 2025-09-26 13:59:12 +02:00

Use PowerShell module and improved xtchain ps1 2ecef29aa4

belliash requested review from harraiken 2025-09-26 14:10:40 +02:00

harraiken commented

2025-09-26 20:25:31 +02:00

Owner

I have reviewed this pull request and decided to close it. The changes do not actually solve the original problem. They mainly rely on Import-Module $modulePath -Force -Global to make the functions global so they persist after the script finishes. That leaves no clean way to unload the environment except by closing the terminal, which is not acceptable. On top of that, when you run the script by double-clicking it, the process still exits with the terminal anyway, so it is not actually a real solution.

In addition, the PR is not limited to just making functions global. It essentially refactors the code and even renames commands. While aliases are added, the help text marks them as legacy, and the renamed commands break compatibility with the Linux version of the environment, which uses the original names. Maintaining command compatibility across platforms is important, so this is another reason why the PR can not be accepted.

For these reasons, this pull request is being closed.

I have reviewed this pull request and decided to close it. The changes do not actually solve the original problem. They mainly rely on ``Import-Module $modulePath -Force -Global`` to make the functions global so they persist after the script finishes. That leaves no clean way to unload the environment except by closing the terminal, which is not acceptable. On top of that, when you run the script by double-clicking it, the process still exits with the terminal anyway, so it is not actually a real solution. In addition, the PR is not limited to just making functions global. It essentially refactors the code and even renames commands. While aliases are added, the help text marks them as legacy, and the renamed commands break compatibility with the Linux version of the environment, which uses the original names. Maintaining command compatibility across platforms is important, so this is another reason why the PR can not be accepted. For these reasons, this pull request is being closed.

harraiken closed this pull request

2025-09-26 20:25:31 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: xt-sys/xtchain#11

Allow edits from maintainers

No description provided.